Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 1passowrd cli to eas-build yml #131

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

RevanToma
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: e04878a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -118,7 +118,21 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4
if: ${{ !inputs.checkout_ref }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den här ska nog inte bort :)

uses: 1password/load-secrets-action/configure@v2
if: ${{ inputs.envTemplateFile }}
env:
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OP_SERVICE_ACCOUNT_TOKEN behöver specas under secrets


- name: Load secret
uses: 1password/load-secrets-action/configure@v2
if: ${{ inputs.envTemplateFile }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envTemplateFile behöver specas under inputs.

Insåg nu också att alla andra variabler här är med underscore så är kör env_template_file istället :)

Copy link
Member

@robertherber robertherber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lgtm 🚀

@RevanToma RevanToma merged commit 36ef447 into main Sep 19, 2024
7 checks passed
@RevanToma RevanToma deleted the expose-env-productions-to-ease-build branch September 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants