-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 1passowrd cli to eas-build yml #131
Conversation
|
@@ -118,7 +118,21 @@ jobs: | |||
steps: | |||
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | |||
- uses: actions/checkout@v4 | |||
if: ${{ !inputs.checkout_ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Den här ska nog inte bort :)
uses: 1password/load-secrets-action/configure@v2 | ||
if: ${{ inputs.envTemplateFile }} | ||
env: | ||
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OP_SERVICE_ACCOUNT_TOKEN behöver specas under secrets
.github/workflows/eas-build.yml
Outdated
|
||
- name: Load secret | ||
uses: 1password/load-secrets-action/configure@v2 | ||
if: ${{ inputs.envTemplateFile }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envTemplateFile behöver specas under inputs.
Insåg nu också att alla andra variabler här är med underscore så är kör env_template_file
istället :)
…erscore instead of dots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, lgtm 🚀
No description provided.