Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added aggregation project and fixed pom files #33

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

brettchaldecott
Copy link
Contributor

@brettchaldecott brettchaldecott commented Nov 1, 2024

Explain your changes

This fixes the aggregation problems and enables correct reporting of coverage.

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Walkthrough

This pull request introduces modifications to the KindeAdminSessionImpl class by removing several import statements and simplifying the authentication logic within the initClient method. The authMap is now exclusively populated with a HttpBearerAuth instance, and OAuth-related logic has been eliminated. Additionally, a new test class ReportTest has been created in the kinde-report-aggregate module, which currently contains a placeholder test method.

Changes

File Path Change Summary
kinde-management/src/main/java/com/kinde/admin/KindeAdminSessionImpl.java Removed import statements and simplified the initClient method by eliminating OAuth logic.
kinde-report-aggregate/src/test/java/com/kinde/ReportTest.java Added a new test class ReportTest with an empty test method as a placeholder for future tests.

Possibly related PRs

  • Fix/cleanup #29: The changes in the KindeAdminSessionImpl class in the main PR and the modifications in the same class in PR Fix/cleanup #29 both involve significant alterations to the authentication logic, indicating a direct relationship in terms of code changes.

Suggested reviewers

  • DaveOrDead
  • rairaman

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0fa14ae and 36ec2c8.

⛔ Files ignored due to path filters (5)
  • .github/workflows/maven.yml is excluded by !**/*.yml
  • kinde-core/pom.xml is excluded by !**/*.xml
  • kinde-management/pom.xml is excluded by !**/*.xml
  • kinde-report-aggregate/pom.xml is excluded by !**/*.xml
  • pom.xml is excluded by !**/*.xml
📒 Files selected for processing (2)
  • kinde-management/src/main/java/com/kinde/admin/KindeAdminSessionImpl.java (0 hunks)
  • kinde-report-aggregate/src/test/java/com/kinde/ReportTest.java (1 hunks)
💤 Files with no reviewable changes (1)
  • kinde-management/src/main/java/com/kinde/admin/KindeAdminSessionImpl.java
✅ Files skipped from review due to trivial changes (1)
  • kinde-report-aggregate/src/test/java/com/kinde/ReportTest.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.35%. Comparing base (0fa14ae) to head (36ec2c8).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #33      +/-   ##
============================================
- Coverage     42.53%   37.35%   -5.18%     
+ Complexity      176      174       -2     
============================================
  Files            53       67      +14     
  Lines           964     1119     +155     
  Branches         76       90      +14     
============================================
+ Hits            410      418       +8     
- Misses          517      663     +146     
- Partials         37       38       +1     
Files with missing lines Coverage Δ
...in/java/com/kinde/admin/KindeAdminSessionImpl.java 20.00% <ø> (+3.33%) ⬆️

... and 14 files with indirect coverage changes

@DanielRivers DanielRivers merged commit e1e5032 into kinde-oss:main Nov 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants