Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(gha): tests workflow did not work with Node.js v14
Browse files Browse the repository at this point in the history
- Fixes the issue that the unit testing workflow did not work with
  Node.js v14 because some of our `devDependencies` required Node.js v16
  or higher. Simply drops "14.x" from the build matrix.
kikuomax committed Nov 13, 2023
1 parent e1e0393 commit 2bf8f3a
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/unit_testing.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
# omits 14.x because some of our devDependencies require 16.x or higher
node-version: [16.x, 18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- uses: actions/checkout@v4
@@ -29,10 +30,5 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
# Node.js v14 bundles npm v6 which does not support workspaces,
# so we need npm v7 or higher that works with Node.js v14.
# we are sure that npm v7 works (npm v10 did not btw.)
- run: npm install -g npm@7
if: ${{ matrix.node-version == '14.x' }}
- run: npm ci
- run: npm -w @ntohq/buefy-next test

0 comments on commit 2bf8f3a

Please sign in to comment.