Some improvements to Tables and OverviewPage

[Lionqueen94]

Description

• ElectionReportPage:
  • Added missing Footer to ElectionReportPage
• Table:
  • Made sure Table.LinkRow last Cell has increased padding to make sure the padding around the Chevron is as designed
  • Made sure all Table functions accept a className
  • Renamed Table.Column to Table.HeaderCell since it can also be used in a row
  • Added a scope="row" | "col" with a default set to "col" to Table.HeaderCell to allow row th usage
  • Made sure Table.HeaderCell can have no children, equal to the implementation of Table.Cell
• OverviewPage:
  • Showing a message that no elections exist on OverviewPage instead of throwing a harsh error, separate designs for typist and administrator are implemented
  • Added tests for OverviewPage
• Polling Station Choice Page:
  • Made sure there is no empty table when there are no polling stations to input on polling station choice page:
    
• Colors:
  • Corrected error icon color in Alert, ProgressList and StatusList and small alert text color
  • Set the correct gray color for the Chevron in the icon with fill because background-image color cannot be set, meaning the Chevron in the Table.LinkRow was black instead of gray

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (35cbdd9) to head (20d7838).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   89.85%   90.19%   +0.33%     
==========================================
  Files         249      249              
  Lines       13073    13090      +17     
  Branches     1328     1338      +10     
==========================================
+ Hits        11747    11806      +59     
+ Misses       1232     1190      -42     
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2025-02-12.

👍 What went well?

You fixed or improved 1 refactoring candidates.

Risk	System property	Location
🟡	Unit Size (Improved)	frontend/app/component/form/data_entry/polling_station_choice/PollingStationsList.tsx PollingStationsList.tsx.PollingStationsList(PollingStationsListProps)

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk	System property	Location
🟡	Unit Size (Worsened)	frontend/app/component/form/data_entry/polling_station_choice/PollingStationChoiceForm.tsx PollingStationChoiceForm.tsx.PollingStationChoiceForm(PollingStationChoiceFormProps)

📚 Remaining technical debt

8 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property	System on 2025-02-12	Before changes	New/changed code
Volume	5.2	N/A	N/A
Duplication	4.3	5.5	5.5
Unit Size	2.4	2.7	2.9
Unit Complexity	3.4	3.2	3.3
Unit Interfacing	3.0	5.5	5.5
Module Coupling	4.0	5.5	5.5
Component Independence	2.8	N/A	N/A
Component Entanglement	3.7	N/A	N/A
Maintainability	3.6	4.3	4.4

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.

• ✅ Yes, these findings are useful
• 🔸 The findings are false positives
• 🔹 These findings are not important to me

---

View this system in Sigrid