Replace Tarpaulin by cargo-llvm-cov for coverage #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praseodym
added
backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 85.21% 86.42% +1.21%
==========================================
Files 257 257
Lines 10571 13094 +2523
Branches 1135 1246 +111
==========================================
+ Hits 9008 11317 +2309
- Misses 1543 1688 +145
- Partials 20 89 +69 ☔ View full report in Codecov by Sentry. |
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
|
If we want branch coverage we do need nightly, see: #934 (comment) |
Also disable file search and fail on upload error.
praseodym
force-pushed
the
934-rust-code-coverage
branch
from
5b5e6b9 to
6845cfd
Compare
Lionqueen94
approved these changes
Jan 30, 2025
marlonbaeten
approved these changes
Jan 30, 2025
marlonbaeten
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to cargo-llvm-cov resolves false negatives in our code coverage. Resolves #934