Master Thesis - Node Scaling - Code Review

.vscode/launch.json

@@ -14,6 +14,19 @@
             "outFiles": ["${workspaceFolder}/applications/klighd-vscode/dist/**/*.js"],
             "preLaunchTask": "${defaultBuildTask}"
         },
+        {
+            "name": "Launch VS Code Extension (socket)",
+            "type": "extensionHost",
+            "request": "launch",
+            "args": ["--extensionDevelopmentPath=${workspaceFolder}/applications/klighd-vscode"],
+            "env": {
+                "KEITH_LS_PORT": "5007"
+            },
+            "sourceMaps": true,
+            "smartStep": true,
+            "outFiles": ["${workspaceFolder}/applications/klighd-vscode/dist/**/*.js"],
+            "preLaunchTask": "${defaultBuildTask}"
+        },
         {
             "name": "Start CLI Webserver",
             "type": "node",

applications/klighd-cli/package.json

@@ -20,7 +20,7 @@
     "clean": "rm -rf lib dist bin",
     "lint": "eslint .",
     "build": "run-p --print-label \"build:*\"",
-    "build:app": "webpack --mode production --devtool hidden-source-map",
+    "build:app": "webpack --mode development --devtool eval-source-map",
     "build:server": "tsc -p ./tsconfig.server.json",
     "watch": "run-p --print-label \"watch:*\"",
     "watch:app": "webpack --watch",

packages/klighd-core/src/bookmarks/bookmark-panel.tsx

@@ -3,7 +3,7 @@
  * KIELER - Kiel Integrated Environment for Layout Eclipse RichClient
  *
  * http://rtsys.informatik.uni-kiel.de/kieler
- * 
+ *
  * Copyright 2021 by
  * + Kiel University
  *   + Department of Computer Science
@@ -172,8 +172,8 @@ export class BookmarkPanel extends SidebarPanel {
         const save = document.getElementById(bookmark.saveId);
         if (save && bookmark.bookmarkIndex !== undefined) {
             save.classList.toggle("options__hidden", true)
-            const new_name = save.getElementsByTagName("input")[0].value ?? undefined;
-            this.actionDispatcher.dispatch(RenameBookmarkAction.create(bookmark.bookmarkIndex, new_name));
+            const newName = save.getElementsByTagName("input")[0].value ?? undefined;
+            this.actionDispatcher.dispatch(RenameBookmarkAction.create(bookmark.bookmarkIndex, newName));
         }
     }
 

packages/klighd-core/src/bookmarks/bookmark-registry.ts

@@ -2,7 +2,7 @@
  * KIELER - Kiel Integrated Environment for Layout Eclipse RichClient
  *
  * http://rtsys.informatik.uni-kiel.de/kieler
- * 
+ *
  * Copyright 2021 by
  * + Kiel University
  *   + Department of Computer Science
@@ -27,7 +27,7 @@ import { AddBookmarkAction, Bookmark, DeleteBookmarkAction, GoToBookmarkAction,
  * A simple {@link Registry} that holds a list of all added Bookmarks
  *
  * Handles CreateBookmark and GoToBookmark actions
- * 
+ *
  */
 @injectable()
 export class BookmarkRegistry extends Registry {
@@ -50,11 +50,11 @@ export class BookmarkRegistry extends Registry {
 
         } else if (DeleteBookmarkAction.isThisAction(action)) {
 
-            this.deleteBookmark(action.bookmark_index)
+            this.deleteBookmark(action.bookmarkIndex)
 
         } else if (RenameBookmarkAction.isThisAction(action)) {
 
-            this.updateBookmarkName(action.bookmark_index, action.new_name)
+            this.updateBookmarkName(action.bookmarkIndex, action.newName)
 
         } else if (AddBookmarkAction.isThisAction(action)) {
 
@@ -69,19 +69,19 @@ export class BookmarkRegistry extends Registry {
         this.notifyListeners();
     }
 
-    protected deleteBookmark(bookmark_index: number): void {
-        const index = this._bookmarks.findIndex((value) => value.bookmarkIndex === bookmark_index);
+    protected deleteBookmark(bookmarkIndex: number): void {
+        const index = this._bookmarks.findIndex((value) => value.bookmarkIndex === bookmarkIndex);
         this._bookmarks.splice(index, 1)
         this.notifyListeners();
     }
 
-    protected updateBookmarkName(bookmark_index: number, new_name: string): void {
-        const bm = this._bookmarks.find((bm) => bm.bookmarkIndex === bookmark_index)
+    protected updateBookmarkName(bookmarkIndex: number, newName: string): void {
+        const bm = this._bookmarks.find((bm) => bm.bookmarkIndex === bookmarkIndex)
         if (bm) {
-            if (new_name === "") {
+            if (newName === "") {
                 bm.name = undefined
             } else {
-                bm.name = new_name
+                bm.name = newName
             }
             this.notifyListeners();
         }

packages/klighd-core/src/bookmarks/bookmark.ts

@@ -2,7 +2,7 @@
  * KIELER - Kiel Integrated Environment for Layout Eclipse RichClient
  *
  * http://rtsys.informatik.uni-kiel.de/kieler
- * 
+ *
  * Copyright 2021 by
  * + Kiel University
  *   + Department of Computer Science
@@ -168,16 +168,16 @@ export namespace AddBookmarkAction {
  */
 export interface DeleteBookmarkAction extends Action {
     kind: typeof DeleteBookmarkAction.KIND
-    bookmark_index: number
+    bookmarkIndex: number
 }
 
 export namespace DeleteBookmarkAction {
     export const KIND = 'delete-bookmark'
 
-    export function create(bookmark_index: number): DeleteBookmarkAction {
+    export function create(bookmarkIndex: number): DeleteBookmarkAction {
         return {
             kind: KIND,
-            bookmark_index,
+            bookmarkIndex,
         }
     }
 
@@ -189,18 +189,18 @@ export namespace DeleteBookmarkAction {
 
 export interface RenameBookmarkAction extends Action {
     kind: typeof RenameBookmarkAction.KIND
-    bookmark_index: number
-    new_name: string
+    bookmarkIndex: number
+    newName: string
 }
 
 export namespace RenameBookmarkAction {
     export const KIND = 'rename-bookmark'
 
-    export function create(bookmark_index: number, new_name: string): RenameBookmarkAction {
+    export function create(bookmarkIndex: number, newName: string): RenameBookmarkAction {
         return {
             kind: KIND,
-            bookmark_index,
-            new_name,
+            bookmarkIndex,
+            newName,
         }
     }
 
@@ -280,4 +280,4 @@ export namespace SetInitialBookmarkAction {
     export function isThisAction(action: Action): action is SetInitialBookmarkAction {
         return action.kind === SetInitialBookmarkAction.KIND;
     }
-}
+}