Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.100.x-prod] use maven-deploy-plugin version defined in apache parent plugin management section #43

Merged

Conversation

rgdoliveira
Copy link
Member

@rgdoliveira rgdoliveira commented May 13, 2024

This fix a failure on PNC when deploying:
Found multiple major versions of maven-deploy-plugin; this is a malformed project: [org.apache.maven.plugins:maven-deploy-plugin:maven-plugin:2.8.2:runtime, org.apache.maven.plugins:maven-deploy-plugin:maven-plugin:3.1.1:runtime] -> [Help 1]

Related PRs

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ement section

This fix a failure on PNC when deploying:
Found multiple major versions of maven-deploy-plugin; this is a malformed project: [org.apache.maven.plugins:maven-deploy-plugin:maven-plugin:2.8.2:runtime, org.apache.maven.plugins:maven-deploy-plugin:maven-plugin:3.1.1:runtime] -> [Help 1]
@mareknovotny
Copy link
Member

ok, question is if there won't be any breaking new features like the change from 2.8.2 to 3.1.1 can be a big due major version change

@rgdoliveira
Copy link
Member Author

ok, question is if there won't be any breaking new features like the change from 2.8.2 to 3.1.1 can be a big due major version change

Thats a good question, I suppose not as this is "just" the deploy plugin, but I believe I will be only 100% sure after merging it and giving it a try.

@rgdoliveira
Copy link
Member Author

rgdoliveira commented May 13, 2024

Kogito-examples failed with error:

2024-05-13T08:11:12.6261298Z install[command]/opt/hostedtoolcache/maven/3.9.3/x64/bin/mvn dependency:tree -pl :kogito-examples clean install -Dproductized -nsu -ntp -fae -e -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dmaven.wagon.http.retryHandler.count=3 -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -B
2024-05-13T08:11:13.6373032Z [INFO] Error stacktraces are turned on.
2024-05-13T08:11:13.6783181Z [INFO] Scanning for projects...
2024-05-13T08:11:14.0207016Z [ERROR] [ERROR] Some problems were encountered while processing the POMs:
2024-05-13T08:11:14.0209748Z [ERROR] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin must be a valid version but is '${version.deploy.plugin}'. @ line 274, column 20
2024-05-13T08:11:14.0211245Z  @ 
2024-05-13T08:11:14.0211830Z [ERROR] The build could not read 1 project -> [Help 1]
2024-05-13T08:11:14.0213092Z org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
2024-05-13T08:11:14.0215677Z [ERROR] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin must be a valid version but is '${version.deploy.plugin}'. @ line 274, column 20

It seems it needs: kiegroup/kogito-examples#30

@rgdoliveira rgdoliveira merged commit fef23f3 into kiegroup:9.100.x-prod May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants