[JBPM-10187] Sorting resources to avoid deadlock

[fjtirado]

JIRA:

link

referenced Pull Requests:
kiegroup/jbpm#2318

[mareknovotny]

jenkins do fdb

[gmunozfe]

@fjtirado Sorry, I didn't include the import in my comment and compilation fails:
16:03:42 [ERROR] /home/jenkins/workspace/KIE/7.x/pullrequest/drools-7.x.pr/bc/kiegroup_drools/drools-persistence/drools-persistence-api/src/main/java/org/drools/persistence/api/TransactionManagerHelper.java:[64,61] cannot find symbol
16:03:42 symbol: variable Comparator
16:03:42 location: class org.drools.persistence.api.TransactionManagerHelper

[mareknovotny]

so can you suggest proper import then? @gmunozfe

[fjtirado]

so can you suggest proper import then? @gmunozfe

@mareknovotny @gmunozfe

Im trying to fix the issue, but Im getting this when forcing the push

Repository https://github.com/kiegroup/drools.git

pre-receive hook declined

[mareknovotny]

hmm, what is your push command? @fjtirado
I would expect as you pushed this branch before it should work for you, but i will check if by any chance this branch is not by protected pattern guarded

UPDATE: no, this branch is not guarded by protected branch pattern

[fjtirado]

hmm, what is your push command? @fjtirado I would expect as you pushed this branch before it should work for you, but i will check if by any chance this branch is not by protected pattern guarded

UPDATE: no, this branch is not guarded by protected branch pattern

I edited directly in the PR, I was messing up with branches from my IDE, sorry about that

[mareknovotny]

jenkins retest this please

[mareknovotny]

there is some weird sonarcloud analysis error not related to this change, i am not able to reproduce it locally yet. My local build fails on h2 persistence module due Caused by: org.h2.jdbc.JdbcSQLException: Feature not supported: "-ifNotExists" [50100-197]
but there were removed org.drools:drools project in Sonarcloud due Apache migration of repository, but now it should be recreated for 7.x branch. But this is not clear as not fixed. I am trying to sort this as it affect all Drools PR here in this repository

[mareknovotny]

jenkins retest this please

i recreated org.drools:drools project on sonarcloud.io so we will see if that is enough to pass it

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

71.9% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.