Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-27] Chain-status tool usage documentation #31

Merged
merged 5 commits into from
Aug 16, 2022
Merged

[ISSUE-27] Chain-status tool usage documentation #31

merged 5 commits into from
Aug 16, 2022

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Aug 9, 2022

Thank you for submitting this pull request

fix:

referenced Pull Requests:

Added a brief documentation on how to use this tool in custom projects.

@lampajr lampajr marked this pull request as ready for review August 10, 2022 10:52
@Ginxo Ginxo self-requested a review August 10, 2022 10:56
Copy link
Collaborator

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments. Please add Working example at the beginning of the documentation pointing to the one from kiegroup, this way it will be easier to have a clearer view of what this tool is, wdyt?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Ginxo Ginxo requested a review from rgdoliveira August 10, 2022 11:01
Co-authored-by: Enrique Mingorance Cano <[email protected]>
@lampajr
Copy link
Member Author

lampajr commented Aug 10, 2022

please check my comments. Please add Working example at the beginning of the documentation pointing to the one from kiegroup, this way it will be easier to have a clearer view of what this tool is, wdyt?

I agree on the example, wdyt if I also add https://github.com/lampajr/chain-status-example/ this one (as a very simple external project)? Where maybe I could also add another configuration using the list of projects (when #33 will be completed)

@lampajr lampajr requested a review from Ginxo August 10, 2022 12:46
@lampajr lampajr changed the title ISSUE-27 Chain-status tool usage documentation [ISSUE-27] Chain-status tool usage documentation Aug 10, 2022
@Ginxo
Copy link
Collaborator

Ginxo commented Aug 11, 2022

please check my comments. Please add Working example at the beginning of the documentation pointing to the one from kiegroup, this way it will be easier to have a clearer view of what this tool is, wdyt?

I agree on the example, wdyt if I also add https://github.com/lampajr/chain-status-example/ this one (as a very simple external project)? Where maybe I could also add another configuration using the list of projects (when #33 will be completed)

@lampajr I agree

Copy link
Collaborator

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ginxo Ginxo merged commit 4ac20d8 into kiegroup:main Aug 16, 2022
@Ginxo Ginxo mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants