Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SKFP-1283 Adjust Cypress tests after ETLs run #4125

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

kstonge
Copy link
Collaborator

@kstonge kstonge commented Sep 25, 2024

FEAT

  • closes #SKFP-1283

Copy link

github-actions bot commented Sep 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 4c4eccb

Copy link
Contributor

@evans-g-crsj evans-g-crsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour les séquences qui se répètent, on devrait utiliser des variables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nombres magiques, je suggère d'utiliser des variables avec des noms parlant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

même commentaire que plus haut

@kstonge kstonge merged commit 75dbfeb into dev Sep 26, 2024
9 checks passed
@kstonge kstonge deleted the cypress/skfp-1283 branch September 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants