-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add docs for contributing to the dataservice #683
Open
chris-s-friedman
wants to merge
1
commit into
master
Choose a base branch
from
docs/cf/contributing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7cde05
to
1304995
Compare
znatty22
reviewed
Sep 5, 2024
57ad790
to
47a6547
Compare
znatty22
reviewed
Sep 5, 2024
📝 Add contributing docs 🚨 Fix codacy issues 🚨 Hopefully adding some text after first heading helps 🚨 Removed the md043 linting Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> 🚨 Fi linting issues 📝 Updating docs Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> Update CONTRIBUTING.md Co-authored-by: Natasha Singh <[email protected]> 📝 Move migration before testing 📝 Put diagram in a code block
754f688
to
d1595e3
Compare
znatty22
reviewed
Sep 10, 2024
the new field: | ||
|
||
```python | ||
:param new_field_name: Description of the new field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
:param new_field_name: Description of the new field. | |
:param new_field_name: Description of the new field. | |
:type new_field_name: <type of new_field_name> |
znatty22
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved for future, but left just one minor comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for contributing to the dataservice. right now, this discusses adding new fields, making PR's and releasing new versions