Skip to content

Commit

Permalink
PM-42093 fixed typo and improved docs
Browse files Browse the repository at this point in the history
  • Loading branch information
mk-kialo committed Sep 11, 2023
1 parent 6978354 commit c72beae
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/moodle-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ defaults:
jobs:
release:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' or github.event.workflow_dispatch.inputs.tag }}
if: ${{ github.event.workflow_run.conclusion == 'success' || github.event.workflow_dispatch.inputs.tag }}
env:
PLUGIN: mod_kialo
CURL: curl -s
Expand Down
6 changes: 4 additions & 2 deletions development/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,13 @@ We use GitHub Actions to automatically create a release whenever a new tag is pu
See `.github/workflows/moodle-release.yml` for details.

To create a new release, follow these steps:
1. Ensure the version in `version.php` has been incremented.
1. Ensure the version in `version.php` has been incremented. Commit and push the change.
2. Create a new tag, e.g. `git tag v1.2.3`
3. Push the tag to GitHub: `git push origin v1.2.3`
4. Wait for the release to be created on GitHub. This can take a few minutes.
5. Check the release [on GitHub](https://github.com/kialo/moodle-mod_kialo/releases) and ensure the zip file is attached.
See https://github.com/kialo/moodle-mod_kialo/actions/workflows/moodle-release.yml.
Note that the release workflow is only triggered once the CI for the new tag has completed successfully.
5. Check the release [on GitHub](https://github.com/kialo/moodle-mod_kialo/releases) and ensure the `mod_kialo.zip` file is attached.
6. Check the release on https://moodle.org/plugins/mod_kialo and ensure the version number is correct.

### Manual Release
Expand Down
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
/** @var stdClass $plugin */
$plugin->component = 'mod_kialo';
$plugin->release = '1.0.15';
$plugin->version = 2023091102;
$plugin->version = 2023091102; // Must be incremented for each new release!

// Officially we require PHP 7.4. The first Moodle version that requires this as a minimum is Moodle 4.1.
// But technically this plugin also runs on older Moodle versions, as long as they run on PHP 7.4,
Expand Down

0 comments on commit c72beae

Please sign in to comment.