Skip to content

Commit

Permalink
PM-43593 review comments
Browse files Browse the repository at this point in the history
- removed superfluous feature
- fixed comments
  • Loading branch information
mk-kialo committed Sep 30, 2024
1 parent 11ef9f7 commit b85b366
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ function xmldb_kialo_upgrade($oldversion = 0): bool {
$dbman = $DB->get_manager();

if ($oldversion < VERSION_GRADING_1) {
// Define field id to be added to kialo.
// Define field 'grade' to be added to kialo.
$table = new xmldb_table('kialo');
$field = new xmldb_field('grade', XMLDB_TYPE_INTEGER, '10', false, XMLDB_NOTNULL, false, 100, null);

// Conditionally launch add field id.
// Conditionally launch add field 'grade'.
if (!$dbman->field_exists($table, $field)) {
$dbman->add_field($table, $field);
}
Expand Down
1 change: 0 additions & 1 deletion lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ function kialo_supports($feature) {
return true;

case FEATURE_GRADE_HAS_GRADE:
case FEATURE_GRADE_OUTCOMES:
return true;

default:
Expand Down

0 comments on commit b85b366

Please sign in to comment.