PM-46464 fix optional params

kialo · Aug 28, 2024 · a29ae40 · a29ae40
1 parent ed8a077
commit a29ae40
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/classes/lti_flow.php b/classes/lti_flow.php
@@ -141,8 +141,8 @@ public static function assign_lti_roles($context): array {
      * @param string $deploymentid
      * @param string $moodleuserid
      * @param string $discussionurl
-     * @param string $groupid
-     * @param string $groupname
+     * @param string|null $groupid
+     * @param string|null $groupname
      * @return LtiMessageInterface
      * @throws LtiExceptionInterface
      * @throws \coding_exception
@@ -154,8 +154,8 @@ public static function init_resource_link(
         string $deploymentid,
         string $moodleuserid,
         string $discussionurl,
-        string $groupid,
-        string $groupname
+        ?string $groupid = null,
+        ?string $groupname = null
     ): LtiMessageInterface {
         $context = context_module::instance($coursemoduleid);
         $roles = self::assign_lti_roles($context);

diff --git a/tests/classes/lti_flow_test.php b/tests/classes/lti_flow_test.php
@@ -351,9 +351,7 @@ public function test_init_resource_link(): void {
             $this->cmid,
             $deploymentid,
             $this->user->id,
-            $discussionurl,
-            "",
-            ""
+            $discussionurl
         );
         $this->assertNotNull($message);
 

diff --git a/view.php b/view.php
@@ -71,8 +71,8 @@
         $moduleinstance->deployment_id,
         $USER->id,
         $moduleinstance->discussion_url,
-        $groupinfo->groupid ?? "",
-        $groupinfo->groupname ?? "",
+        $groupinfo->groupid,
+        $groupinfo->groupname,
     );
 
     $output = $PAGE->get_renderer('mod_kialo');