PM-46464 adjusting typing to appease bug in moodle-plugin-ci linting …

…rules
kialo · Aug 28, 2024 · 6f4c630 · 6f4c630
1 parent 10d315b
commit 6f4c630
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/classes/lti_flow.php b/classes/lti_flow.php
@@ -154,8 +154,8 @@ public static function init_resource_link(
         string $deploymentid,
         string $moodleuserid,
         string $discussionurl,
-        ?string $groupid = null,
-        ?string $groupname = null
+        string $groupid,
+        string $groupname
     ): LtiMessageInterface {
         $context = context_module::instance($coursemoduleid);
         $roles = self::assign_lti_roles($context);

diff --git a/tests/classes/lti_flow_test.php b/tests/classes/lti_flow_test.php
@@ -346,7 +346,15 @@ public function test_init_resource_link(): void {
         // Construct the initial LTI message sent to Kialo when the user clicks on the activity.
         $deploymentid = "random-string-123";
         $discussionurl = "random-discussion-url.com";
-        $message = lti_flow::init_resource_link($this->course->id, $this->cmid, $deploymentid, $this->user->id, $discussionurl);
+        $message = lti_flow::init_resource_link(
+            $this->course->id,
+            $this->cmid,
+            $deploymentid,
+            $this->user->id,
+            $discussionurl,
+            null,
+            null
+        );
         $this->assertNotNull($message);
 
         $params = $message->getParameters()->jsonSerialize();