-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hack] a script that can be used to smoke test the latest release #220
Conversation
8cefbb8
to
e4c4d78
Compare
We will be able to use this in a github action when we release the helm charts.
e4c4d78
to
41f2bf4
Compare
You can confirm the new github action works by looking at my test PR over in my fork: jmazzitelli#2 Notice that because the helm chart index was changed (which happens when new helm charts are released), that triggered the new workflow which runs the new smoke test script. See the successful smoke test run here: https://github.com/jmazzitelli/helm-charts/actions/runs/5795882447/job/15708303878?pr=2#step:3:83 |
and that normally only happens in release PRs. This will smoke test the latest release found in the PR branch.
41f2bf4
to
8be0d2d
Compare
@jmazzitelli I'm running this script locally and I'm hitting the following issue:
I'm just running the script with no parameters. I can confirm that the pod is there, I will continue troubleshooting, any idea?. |
That's weird it is running with version 1.61.0. Are you testing that? Look at the output of the script and see what release branch it thinks it is using. Make sure when you pull this PR you merge it on top of a master branch. It is going to look at "origin"'s branches and try to find the latest helm-charts-releases branch. It might be your fork doesn't have all of them fetched? |
Yeah, it's true, but I synced my fork and it's doing the same thing, I'm not sure why it's picking: [HACK] Will smoke test remote release branch [origin/helm-charts-release-58-main] Shouldn't be using master?. |
No, I wrote the script so by default it will try to find the latest In fact, I don't even know how you are picking up Do a
|
OK, that is the issue, I generally use "origin" for my fork, and "upstream" for the upstream repo. Now it works, I used your recommended parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good:
[HACK] =========================
[HACK] The smoke test has PASSED
[HACK] =========================
…ali#220) * [hack] a script that can be used to smoke test the latest release We will be able to use this in a github action when we release the helm charts. * a github workflow that runs whenever a PR touches the docs/index.yaml, and that normally only happens in release PRs. This will smoke test the latest release found in the PR branch.
We can now use this script after each release to confirm the helm charts that are about to be published actually work.
You should just be able to run
smoke-test-release-branch.sh
but there are some cmdline options you can use to customize it in case you want to test on, say, your own remote repo.Also included is a new CI workflow to automatically run this script on release PRs (or any PR that modifies the published helm charts index file).