Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Align object names with README #52

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

orelmisan
Copy link
Member

Following PR #23, the repo's name was changed from kubevirt-rt-checkup to kubevirt-realtime-checkup.

In PR #27, a README file was added with object names conforming to the new name of the repo.

Align the object names with the README file.

@orelmisan orelmisan requested a review from RamLavi December 18, 2023 07:51
@orelmisan
Copy link
Member Author

Tested against an OpenShift Virtualization 4.15 cluster.

RamLavi
RamLavi previously approved these changes Dec 18, 2023
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Following PR kiagnose#23, the repo's name was changed from
`kubevirt-rt-checkup` to `kubevirt-realtime-checkup`.

In PR kiagnose#27, a README file was added with object names
conforming to the new name of the repo.

Align the object names with the README file.

Signed-off-by: Orel Misan <[email protected]>
@RamLavi
Copy link
Collaborator

RamLavi commented Dec 18, 2023

Can you fix the lint issue?

In order to make names more explicit,
expend the `RT` acronym to `RealTime`.

Signed-off-by: Orel Misan <[email protected]>
@orelmisan
Copy link
Member Author

Change: Rebase + fix linter issue.

@orelmisan
Copy link
Member Author

E2E test passed after the change.

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@orelmisan orelmisan merged commit ae7edc1 into kiagnose:main Dec 18, 2023
5 checks passed
@orelmisan orelmisan deleted the align-e2e-names branch December 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants