Skip to content

Commit

Permalink
checkup: Remove IOThread Policy from VMI
Browse files Browse the repository at this point in the history
In preparation to mounting a configmap to the realtime VMI, removeing
the existing IOThread policy, as the former uses a SATA bus [0] and the
latter is not supported with SATA devices [0].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1911590

Signed-off-by: Ram Lavi <[email protected]>
  • Loading branch information
RamLavi committed Mar 21, 2024
1 parent bde8109 commit fe4406d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion pkg/internal/checkup/checkup.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ func newRealtimeVMI(checkupConfig config.Config) *kvcorev1.VirtualMachineInstanc
vmi.WithoutAutoAttachGraphicsDevice(),
vmi.WithoutAutoAttachMemBalloon(),
vmi.WithAutoAttachSerialConsole(),
vmi.AutoIOThreadPolicy(),
vmi.WithZeroTerminationGracePeriodSeconds(),
vmi.WithNodeSelector(checkupConfig.VMUnderTestTargetNodeName),
vmi.WithContainerDisk(rootDiskName, checkupConfig.VMUnderTestContainerDiskImage),
Expand Down
6 changes: 0 additions & 6 deletions pkg/internal/checkup/vmi/vmi.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,6 @@ func WithAutoAttachSerialConsole() Option {
}
}

func AutoIOThreadPolicy() Option {
return func(vmi *kvcorev1.VirtualMachineInstance) {
vmi.Spec.Domain.IOThreadsPolicy = Pointer(kvcorev1.IOThreadsPolicyAuto)
}
}

func WithVirtIODisk(name string) Option {
return func(vmi *kvcorev1.VirtualMachineInstance) {
vmi.Spec.Domain.Devices.Disks = append(vmi.Spec.Domain.Devices.Disks, kvcorev1.Disk{
Expand Down

0 comments on commit fe4406d

Please sign in to comment.