exclude names when repopulating attrs. fixes #16

khusmann · Oct 12, 2024 · 24be795 · 24be795
1 parent fb842a9
commit 24be795
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/R/interlaced.R b/R/interlaced.R
@@ -96,7 +96,7 @@ new_interlaced <- function(value_channel, na_channel, ...) {
   )
 
   for (i in names(attributes(value_channel))) {
-    if (i != "class") {
+    if (i != "class" && i != "names") {
       if (!is.null(attr(v, i))) {
         cli_abort("attribute {i} in value vector conflicts with interlaced")
       }

diff --git a/tests/testthat/test-interlaced.R b/tests/testthat/test-interlaced.R
@@ -222,3 +222,10 @@ test_that("model.frame drops na_channel", {
   expect_equal(value_channel(mod$b), c(1, 3))
   expect_equal(na_channel(mod$b), unspecified(2))
 })
+
+test_that("vector names are preserved", {
+  foo <- interlaced(c(a=1, b=2, c=-99), c(-99))
+
+  expect_equal(names(foo), c("a", "b", "c"))
+  expect_equal(value_channel(foo), c(a=1, b=2, c=NA))
+})