Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency mongoose to v8.9.5 [security] #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 19, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
mongoose (source) 8.8.3 -> 8.9.5 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-23061

Mongoose versions prior to 8.9.5, 7.8.4, and 6.13.6 are vulnerable to improper use of the $where operator. This vulnerability arises from the ability of the $where clause to execute arbitrary JavaScript code in MongoDB queries, potentially leading to code injection attacks and unauthorized access or manipulation of database data.

NOTE: this issue exists because of an incomplete fix for CVE-2024-53900.


Release Notes

Automattic/mongoose (mongoose)

v8.9.5

Compare Source

==================

v8.9.4

Compare Source

==================

  • fix(document): fix document not applying manual populate when using a function in schema.options.ref #​15138 IchirokuXVI
  • fix(model): make Model.validate() static correctly cast document arrays #​15169 #​15164
  • fix(model): allow passing validateBeforeSave option to bulkSave() to skip validation #​15161 #​15156
  • fix(schema): allow multiple self-referencing discriminator schemas using Schema.prototype.discriminator #​15142 #​15120
  • types: avoid BufferToBinary<> wiping lean types when passed to generic functions #​15160 #​15158
  • docs: fix <code> in header ids #​15159
  • docs: fix header in field-level-encryption.md #​15137 damieng

v8.9.3

Compare Source

==================

  • fix(schema): make duplicate index error a warning for now to prevent blocking upgrading #​15135 #​15112 #​15109
  • fix(model): handle document array paths set to non-array values in Model.castObject() #​15124 #​15075
  • fix(document): avoid using childSchemas.path for compatibility with pre-Mongoose-8.8 schemas #​15131 #​15071
  • fix(model): avoid throwing unnecessary error if updateOne() returns null in save() #​15126
  • perf(cursor): clear the stack every time if using populate with batchSize to avoid stack overflows with large docs #​15136 #​10449
  • types: make BufferToBinary avoid Document instances #​15123 #​15122
  • types(model+query): avoid stripping out virtuals when calling populate with paths generic #​15132 #​15111
  • types(schema): add missing removeIndex #​15134
  • types: add cleanIndexes() to IndexManager interface #​15127
  • docs: move search endpoint to netlify #​15119

v8.9.2

Compare Source

==================

  • fix(schema): avoid throwing duplicate index error if index spec keys have different order or index has a custom name #​15112 #​15109
  • fix(map): clean modified subpaths when overwriting values in map of subdocs #​15114 #​15108
  • fix(aggregate): pull session from transaction local storage for aggregation cursors #​15094 IchirokuXVI
  • types: correctly handle union types in BufferToBinary and related helpers #​15103 #​15102 #​15057
  • types: add UUID to RefType #​15115 #​15101
  • docs: remove link to Mongoose 5.x docs from dropdown #​15116
  • docs(connection+document+model): remove remaining references to remove(), clarify that deleteOne() does not execute until then() or exec() #​15113 #​15107

v8.9.1

Compare Source

==================

  • fix(connection): remove heartbeat check in load balanced mode #​15089 #​15042 #​14812
  • fix(discriminator): gather childSchemas when creating discriminator to ensure $getAllSubdocs() can properly get all subdocs #​15099 #​15088 #​15092
  • fix(model): handle discriminators in castObject() #​15096 #​15075
  • fix(schema): throw error if duplicate index definition using unique in schema path and subsequent .index() call #​15093 #​15056
  • fix: mark documents that are populated using hydratedPopulatedDocs option as populated in top-level doc #​15080 #​15048
  • fix(document+schema): improve error message for get() on invalid path #​15098 #​15071
  • docs: remove more callback doc references & some small other changes #​15095

v8.9.0

Compare Source

==================

v8.8.4

Compare Source

==================

  • fix: cast using overwritten embedded discriminator key when set #​15076 #​15051
  • fix: avoid throwing error if saveOptions undefined when invalidating subdoc cache #​15062

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request updates the mongoose dependency from version 8.8.3 to 8.9.5. This update addresses a security vulnerability related to the improper use of the $where operator, which could lead to code injection attacks. The update also includes several bug fixes and improvements.

Sequence diagram showing potential MongoDB $where operator vulnerability

sequenceDiagram
    actor Attacker
    participant App as Application
    participant Mongoose as Mongoose v8.8.3
    participant DB as MongoDB

    Note over Attacker, DB: Before patch (vulnerable)
    Attacker->>App: Send malicious query with nested $where
    App->>Mongoose: Execute query
    Mongoose->>DB: Forward query with $where
    DB->>DB: Execute arbitrary JavaScript
    DB-->>Mongoose: Return results
    Mongoose-->>App: Return results

    Note over Attacker, DB: After patch (v8.9.5)
    Attacker->>App: Send malicious query with nested $where
    App->>Mongoose: Execute query
    Mongoose->>Mongoose: Block nested $where in populate match
    Mongoose-->>App: Throw security error
Loading

File-Level Changes

Change Details Files
Updated mongoose dependency to address a security vulnerability and include bug fixes.
  • Updated mongoose from 8.8.3 to 8.9.5.
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

coderabbitai bot commented Jan 19, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants