This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Upgrade herrera-io/json dependency to 2.* version #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
herrera-io/json
dependency version to2.*
branch.Why?
With current sticking to
1.*
version this project creates problems in dependencies resolving.For example (
composer.json
):These are the latest versions of Composer and phpDocumentor at the moment. But Composer won't resolve this, because
phpdocumentor/phpdocumentor
requires this project, and this project requiresherrera-io/json
to be1.*
, and that one requiresjustinrainbow/json-schema
to be>=1.0,<2.0-dev
. Which is incompatible with requirement ofcomposer/composer
(justinrainbow/json-schema
to be^3.0 || ^4.0 || ^5.0
).The only possible way to resolve this at the moment is to downgrade
composer/composer
to~1.3
which considers1.*
versions ofjustinrainbow/json-schema
.Solution
Upgrading
herrera-io/json
to2.*
branch will require a^4.1
ofjustinrainbow/json-schema
, which will cause much less problems in transitive dependencies.