Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some improvements for hiding/locking apps #164

Merged
merged 17 commits into from
Sep 25, 2024

Conversation

fkunn1326
Copy link
Contributor

With #153, we can hidden apps. However, I felt that the experience was not very user-friendly, so I’ve made a few improvements:

  • Enabled hide/strict hide actions without requiring a triple tap.
  • When not in strict hide mode, apps will appear blurred, like this:
ScreenRecording_09-22-2024.16-30-33_1.mov

@boa-z
Copy link

boa-z commented Sep 22, 2024

I think making the app show up blurrily isn't a very good change. It makes people able to see the app icon and defeats the purpose of hiding it.

@fkunn1326
Copy link
Contributor Author

Something like a skeleton screen would be better?

@boa-z
Copy link

boa-z commented Sep 22, 2024

Something like a skeleton screen would be better?

Yeah, that's a good point. In addition, I think the original author's design was intentionally meant to make the entrance more concealed and difficult to find. I think that's a good idea as well.

@hugeBlack
Copy link
Collaborator

Maybe we can add a switch after revealing apps so you can choose what kind of hiding you want.

@fkunn1326
Copy link
Contributor Author

Maybe we can add a switch after revealing apps so you can choose what kind of hiding you want.

There’s a strict hide mode for that, so I think it’s already covered.
and the updated appearance of the hidden apps looks like this:

image

@boa-z
Copy link

boa-z commented Sep 23, 2024

Thank you for the update. The current version is working fine. By the way, you can consider adding a function that only requires a password but not hidden, which similar to iOS18.

@fkunn1326
Copy link
Contributor Author

Locking apps is supported!

ScreenRecording_09-23-2024.14-06-34_1.mov

@fkunn1326 fkunn1326 changed the title Add some improvements for hiding apps Add some improvements for hiding/locking apps Sep 23, 2024
@hugeBlack
Copy link
Collaborator

Great work! I'll do some tests and merge it later. By the way, why did you removed the requirement that the "Strict Hiding Mode" switch requires unlocking to be shown?

@fkunn1326
Copy link
Contributor Author

I felt that it was a bit confusing to find. However, on second thoughts, it might be a great idea the requirement for strict hide mode

@hugeBlack hugeBlack merged commit 1b870ee into khanhduytran0:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants