Cleanup

khanhduytran0 · Apr 22, 2024 · ebea623 · ebea623
1 parent a76df13
commit ebea623
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/LCJITLessSetupViewController.m b/LCJITLessSetupViewController.m
@@ -19,9 +19,11 @@ - (void)loadView {
     self.title = @"LiveContainer JIT-less setup";
 
     NSData *certData = [LCUtils keychainItem:@"signingCertificate" ofStore:@"com.SideStore.SideStore"];
+/* TODO: support AltStore
     if (!certData) {
         certData = [LCUtils keychainItem:@"signingCertificate" ofStore:@"com.rileytestut.AltStore"];
     }
+*/
     if (!certData) {
         [self showDialogTitle:@"Error" message:@"Failed to find certificate" handler:nil];
         return;

diff --git a/LCUtils.m b/LCUtils.m
@@ -133,20 +133,13 @@ + (NSProgress *)signAppBundle:(NSURL *)path completionHandler:(void (^)(BOOL suc
     NSURL *profilePath = [NSBundle.mainBundle URLForResource:@"embedded" withExtension:@"mobileprovision"];
 
     // Load libraries from Documents, yeah
-    [[NSBundle bundleWithURL:[storeFrameworksPath URLByAppendingPathComponent:@"OpenSSL.framework"]] loadAndReturnError:&error];
-    if (error) {
-        completionHandler(NO, error);
-        return nil;
-    }
-    [[NSBundle bundleWithURL:[storeFrameworksPath URLByAppendingPathComponent:@"Roxas.framework"]] loadAndReturnError:&error];
-    if (error) {
-        completionHandler(NO, error);
-        return nil;
-    }
-    [[NSBundle bundleWithURL:[storeFrameworksPath URLByAppendingPathComponent:@"AltStoreCore.framework"]] loadAndReturnError:&error];
-    if (error) {
-        completionHandler(NO, error);
-        return nil;
+    NSArray *signerFrameworks = @[@"OpenSSL.framework", @"Roxas.framework", @"AltStoreCore.framework"];
+    for (NSString *framework in signerFrameworks) {
+        [[NSBundle bundleWithURL:[storeFrameworksPath URLByAppendingPathComponent:framework]] loadAndReturnError:&error];
+        if (error) {
+            completionHandler(NO, error);
+            return nil;
+        }
     }
 
     ALTCertificate *cert = [[NSClassFromString(@"ALTCertificate") alloc] initWithP12Data:self.certificateData password:@""];