Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file, reformat TF files, and update README.md #95

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Add CODEOWNERS file, reformat TF files, and update README.md #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# This is a comment
# Specify files or directories followed by the owner
* @khanh-ph
88 changes: 43 additions & 45 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use_legacy_naming_convention = false
# Proxmox VE
########################################################################
# Proxmox VE API details and VM hosting configuration
# API token guide: https://registry.terraform.io/providers/Telmate/proxmox/2.9.14/docs
# API token guide: https://registry.terraform.io/providers/Telmate/proxmox/latest/docs
pm_api_url = "https://your-proxmox-url/api"
pm_api_token_id = "your-api-token-id"
pm_api_token_secret = "your-api-token-secret"
Expand Down
24 changes: 24 additions & 0 deletions modules/proxmox_ubuntu_vm/.terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions modules/proxmox_ubuntu_vm/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ resource "proxmox_vm_qemu" "ubuntu_vm" {
disks {
virtio {
virtio0 {
disk {
size = "${var.vm_os_disk_size_gb}G"
storage = var.vm_os_disk_storage
iothread = true
}
disk {
size = "${var.vm_os_disk_size_gb}G"
storage = var.vm_os_disk_storage
iothread = true
}
}

dynamic "virtio1" {
for_each = var.add_worker_node_data_disk ? [var.worker_node_data_disk_size] : []
Expand Down
8 changes: 4 additions & 4 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ variable "internal_net_subnet_cidr" {

variable "ssh_private_key" {
type = string
description = "SSH private key in base64, will be used by Terraform client to connect to the VM after provisioning"
sensitive = false
description = "SSH private key in base64, will be used by Terraform client to connect to the Kubespray VM after provisioning. We can set its sensitivity to false; otherwise, the output of the Kubespray script will be hidden."
sensitive = false
}

variable "ssh_public_keys" {
type = string
description = "SSH public keys in base64"
sensitive = false
sensitive = false
}

variable "vm_user" {
Expand Down Expand Up @@ -193,7 +193,7 @@ variable "create_kubespray_host" {
variable "kubespray_image" {
type = string
description = "The Docker image to deploy Kubespray"
default = "quay.io/kubespray/kubespray:v2.25.0"
default = "quay.io/kubespray/kubespray:v2.25.0"
}

variable "kube_version" {
Expand Down
Loading