Add CODEOWNERS file and reformat TF files

khanh-ph · Aug 24, 2024 · 10c0ad0 · 10c0ad0
1 parent 8de8cb7
commit 10c0ad0
Show file tree

Hide file tree

Showing 6 changed files with 80 additions and 55 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,3 @@
+# This is a comment
+# Specify files or directories followed by the owner
+*             @khanh-ph
diff --git a/README.md b/README.md
diff --git a/example.tfvars b/example.tfvars
@@ -11,7 +11,7 @@ use_legacy_naming_convention = false
 # Proxmox VE
 ########################################################################
 # Proxmox VE API details and VM hosting configuration
-# API token guide: https://registry.terraform.io/providers/Telmate/proxmox/2.9.14/docs
+# API token guide: https://registry.terraform.io/providers/Telmate/proxmox/latest/docs
 pm_api_url          = "https://your-proxmox-url/api"
 pm_api_token_id     = "your-api-token-id"
 pm_api_token_secret = "your-api-token-secret"

diff --git a/modules/proxmox_ubuntu_vm/.terraform.lock.hcl b/modules/proxmox_ubuntu_vm/.terraform.lock.hcl
diff --git a/modules/proxmox_ubuntu_vm/main.tf b/modules/proxmox_ubuntu_vm/main.tf
@@ -34,12 +34,12 @@ resource "proxmox_vm_qemu" "ubuntu_vm" {
   disks {
     virtio {
       virtio0 {
-          disk {
-            size     = "${var.vm_os_disk_size_gb}G"
-            storage  = var.vm_os_disk_storage
-            iothread = true 
-          }
+        disk {
+          size     = "${var.vm_os_disk_size_gb}G"
+          storage  = var.vm_os_disk_storage
+          iothread = true
         }
+      }
 
       dynamic "virtio1" {
         for_each = var.add_worker_node_data_disk ? [var.worker_node_data_disk_size] : []

diff --git a/variables.tf b/variables.tf
@@ -87,14 +87,14 @@ variable "internal_net_subnet_cidr" {
 
 variable "ssh_private_key" {
   type        = string
-  description = "SSH private key in base64, will be used by Terraform client to connect to the VM after provisioning"
-  sensitive = false
+  description = "SSH private key in base64, will be used by Terraform client to connect to the Kubespray VM after provisioning. We can set its sensitivity to false; otherwise, the output of the Kubespray script will be hidden."
+  sensitive   = false
 }
 
 variable "ssh_public_keys" {
   type        = string
   description = "SSH public keys in base64"
-  sensitive = false
+  sensitive   = false
 }
 
 variable "vm_user" {
@@ -193,7 +193,7 @@ variable "create_kubespray_host" {
 variable "kubespray_image" {
   type        = string
   description = "The Docker image to deploy Kubespray"
-  default = "quay.io/kubespray/kubespray:v2.25.0"
+  default     = "quay.io/kubespray/kubespray:v2.25.0"
 }
 
 variable "kube_version" {