Improve handling of Metadata{StructureDefinition,Set} in SDMX-ML 2.1 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass multiple child elements as positional args to Element(), instead of elem.append() or elem.extend(). - Return created elements immediately without a local variable.
- Write distinct tags for .v21.{Start,End}Period.
- Simplify writing DataKeySet and MemberSelection.
- Avoid use of typing.cast()
- Stash/unstash on AttributeSet, not ReportedAttribute. - Generate concrete subclasses of ReportedAttribute. - Resolve references in TargetIdentifiableObject.
…instead of str/bytes.
This was an erroneous inclusion, not part of the standard.
- Log non-identical members of DictLike. - Log missing components in other ComponentList.
- Streamline .reader.v21._component_end()
Handle the case where the existing object is concrete, not an external reference, but has no URN set (e.g. because not given in the source message) by computing a URN.
- Distinguish NoWriterImplementation from NotImplementedError. - When dispatching to a writer function for the parent class of an object, register that function for the child class directly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 98.90% 97.95% -0.96%
==========================================
Files 97 97
Lines 7699 7839 +140
==========================================
+ Hits 7615 7679 +64
- Misses 84 160 +76
|
Match on a string path fragment (same as test case ID), rather than a complete path object.
Allow non-strict comparison if self.urn is None.
- ReportStructure - IdentifiableObjectTarget - ReportPeriodTarget
Handle cases where objects are included explicitly within a StructureMessage, but with isExternalReference="true", i.e. as "stubs".
khaeru
added a commit
that referenced
this pull request
Sep 3, 2024
khaeru
added a commit
that referenced
this pull request
Nov 5, 2024
Parallel to change for WB_WDI in #192.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changes to doc/whatsnew.
PR checklist