Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .model.version, improve .urn #189

Merged
merged 9 commits into from
Aug 16, 2024
Merged

Add .model.version, improve .urn #189

merged 9 commits into from
Aug 16, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Aug 13, 2024

These support easier and more regular handling of version and URN identifiers for SDMX objects.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added the enh Enhancements & new features label Aug 13, 2024
@khaeru khaeru self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (473f3af) to head (4b129df).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   98.91%   97.92%   -1.00%     
==========================================
  Files          95       97       +2     
  Lines        7539     7699     +160     
==========================================
+ Hits         7457     7539      +82     
- Misses         82      160      +78     
Files Coverage Δ
sdmx/model/common.py 99.90% <100.00%> (ø)
sdmx/model/version.py 100.00% <100.00%> (ø)
sdmx/tests/model/test_version.py 100.00% <100.00%> (ø)
sdmx/tests/test_docs.py 100.00% <100.00%> (ø)
sdmx/tests/test_urn.py 100.00% <100.00%> (ø)
sdmx/urn.py 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

@khaeru khaeru force-pushed the enh/urn-version branch 2 times, most recently from cd32dab to 8317cd7 Compare August 16, 2024 13:16
khaeru added a commit that referenced this pull request Aug 16, 2024
khaeru added a commit that referenced this pull request Aug 16, 2024
@khaeru khaeru merged commit 3b322e3 into main Aug 16, 2024
20 checks passed
@khaeru khaeru deleted the enh/urn-version branch August 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancements & new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant