Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject: Ensure sources.json is installed by setuptools. #185

Closed
wants to merge 1 commit into from

Conversation

nicolas-graves
Copy link

I couldn't build the package from source on Gnu Guix without ensuring the sources.json file is there.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (473f3af) to head (1a4ca5b).
Report is 106 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   98.91%   97.87%   -1.04%     
==========================================
  Files          95       95              
  Lines        7539     7539              
==========================================
- Hits         7457     7379      -78     
- Misses         82      160      +78     

see 18 files with indirect coverage changes

@khaeru
Copy link
Owner

khaeru commented Jul 1, 2024

The repo uses a reusable workflow (this one) to confirms that package can be built properly. Here you can see that it picks up sources.json. This is also the workflow used to push tags (release candidates) and new releases to PyPI. You can also confirm that the releases on PyPI include the file.

Can you please:

  1. Explain which tool(s) (including versions) and exact command(s) you were using to attempt to build and/or install the package, and
  2. Show the complete output?

@khaeru khaeru added the needs-info Needs more info from the issuer to proceed label Jul 1, 2024
@nicolas-graves
Copy link
Author

Sorry I never answered here. It was actually the same command, maybe with an older version of the package. Anyway, if you don't have the issue to publish on pypi, it's not essential, I can keep a vendored patch in Guix ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Needs more info from the issuer to proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants