Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return None if response is empty #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

edkry
Copy link

@edkry edkry commented Apr 11, 2024

Required: If there is no data for a table with specific parameters, it should return None.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.80%. Comparing base (8d5e467) to head (3190fa7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   98.86%   97.80%   -1.07%     
==========================================
  Files          94       94              
  Lines        7431     7433       +2     
==========================================
- Hits         7347     7270      -77     
- Misses         84      163      +79     
Files Coverage Δ
sdmx/client.py 93.51% <50.00%> (-5.40%) ⬇️

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants