Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read/write of common.Contact #159

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Fix read/write of common.Contact #159

merged 4 commits into from
Jan 24, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Jan 24, 2024

  • Attach com:Name to the Agency, not the Contact.
  • Write URI and e-mail as element text, not an attribute named "text".

PR checklist

  • Checks all ✅
  • Update documentation Bug fix
  • Update doc/whatsnew.rst

- Attach <com:Name> to the Agency, not the Contact.
- Write URI and e-mail as element text, not an attribute named "text".
@khaeru khaeru added bug writer Convert objects to other formats xml SDMX-ML format reader Read file formats defined by the SDMX standards labels Jan 24, 2024
@khaeru khaeru self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0e00bc) 98.72% compared to head (c425a6e) 96.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   98.72%   96.51%   -2.21%     
==========================================
  Files          87       87              
  Lines        7043     7055      +12     
==========================================
- Hits         6953     6809     -144     
- Misses         90      246     +156     
Files Coverage Δ
sdmx/reader/xml/v21.py 98.83% <100.00%> (-0.21%) ⬇️
sdmx/tests/reader/test_reader_xml_v21.py 100.00% <100.00%> (ø)
sdmx/tests/writer/test_writer_xml.py 100.00% <ø> (ø)
sdmx/writer/xml.py 97.68% <ø> (ø)

... and 17 files with indirect coverage changes

@khaeru khaeru merged commit 57d4ce3 into main Jan 24, 2024
20 checks passed
@khaeru khaeru deleted the fix/xml-contact branch January 24, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reader Read file formats defined by the SDMX standards writer Convert objects to other formats xml SDMX-ML format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant