Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for validating SDMX-ML v2.1 messages #153

Closed
wants to merge 17 commits into from

Conversation

goatsweater
Copy link

Required: write a single sentence that describes the changes made by this PR.

Add support for validating SDMX-ML messages via sdmx.validate_xml() (Closes #51)

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@goatsweater goatsweater changed the title Validate xml 2.1 xsd Add support for validating SDMX-ML v2.1 messages Jan 3, 2024
@khaeru
Copy link
Owner

khaeru commented Jan 8, 2024

@goatsweater many thanks for the contribution here!

The test failures are due to added specimens for which the support is in #152. So for next steps:

  • I will complete and merge that PR.
  • I will ask you to rebase this branch on main (or I can do that if you don't feel comfortable).
  • Once the checks pass, you can complete the PR description and checklist above.
  • You can request a review from me.

…and then we will go from there.

I will also investigate the settings for this repo so I don't need to manually approve the CI runs on every push you (or other contributors) make to your branch.

@goatsweater
Copy link
Author

@khaeru I saw that you had made some changes since my fork and merged those into this branch. I think that may have messed up the ability to rebase. I'm happy to close this and start over with a proper rebase if you'd like.

@khaeru
Copy link
Owner

khaeru commented Jan 11, 2024

I think that may have messed up the ability to rebase. I'm happy to close this and start over with a proper rebase if you'd like.

If you don't mind, that would be appreciated. Please let me know if you get stuck and I can try to create a new branch by cherry-picking some commits from this one.

In the meantime I'll look at the CLA setup, as promised.

@goatsweater
Copy link
Author

Closing in favor of #154

@goatsweater goatsweater deleted the validate-xml-2.1-xsd branch January 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate SDMX-ML output using XSD
2 participants