Handle valid{From,To} attrs in xml.v21.Reader.maintainable()

khaeru · Oct 9, 2023 · 75921ba · 75921ba
1 parent ad90c6d
commit 75921ba
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/sdmx/reader/xml/v21.py b/sdmx/reader/xml/v21.py
@@ -576,7 +576,15 @@ def maintainable(self, cls, elem, **kwargs):
         the same object ID will return references to the same object.
         """
         kwargs.setdefault("is_external_reference", elem is None)
-        setdefault_attrib(kwargs, elem, "isExternalReference", "isFinal", "version")
+        setdefault_attrib(
+            kwargs,
+            elem,
+            "isExternalReference",
+            "isFinal",
+            "validFrom",
+            "validTo",
+            "version",
+        )
         kwargs["is_final"] = kwargs.get("is_final", None) == "true"
 
         # Create a candidate object
@@ -1393,7 +1401,6 @@ def _cc(reader, elem):
         else:
             content.add(resolved)
 
-    # return reader.nameable(
     return reader.maintainable(
         cls,
         elem,