Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(land): 이미지 파일 확장자 변경, react-hook-form 사용 #271

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

Jeong-Ag
Copy link
Contributor

Summary

#181
이미지 확장자를 변경하고 신청폼에 react hook form을 적용했어요.

Tasks

  • 이미지 확장자 webp로 변경
  • Formreact-form-hook 적용

Screenshot

스크린샷 2025-02-18 오후 5 14 02

@Jeong-Ag Jeong-Ag added 🔨 Refactor 코드 수정 및 최적화 🎈Land land 프로젝트 관련 labels Feb 18, 2025
@Jeong-Ag Jeong-Ag self-assigned this Feb 18, 2025
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 7b168f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (0c66f87) to head (7b168f0).
Report is 120 commits behind head on main.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   94.06%   93.71%   -0.35%     
==========================================
  Files          14       14              
  Lines         219      207      -12     
  Branches       37       38       +1     
==========================================
- Hits          206      194      -12     
  Misses         11       11              
  Partials        2        2              

see 10 files with indirect coverage changes

@Jeong-Ag Jeong-Ag requested review from yummjin and gwansikk February 18, 2025 08:17
Copy link
Member

@gwansikk gwansikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~ 완벽합니다

@Jeong-Ag Jeong-Ag merged commit f818ee8 into main Feb 18, 2025
5 checks passed
@Jeong-Ag Jeong-Ag deleted the refactor/181 branch February 18, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈Land land 프로젝트 관련 🔨 Refactor 코드 수정 및 최적화
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants