feat(time): 모의 수강신청 페이지 개발 #263

yummjin · 2025-01-15T06:00:01Z

Summary

related: #256

모의 수강신청 페이지의 기본적인 타입 설정을 하고, 레이아웃을 만들었습니다.

Tasks

time 작업환경에서 모의 수강신청 페이지로 이어지는 디렉토리 Sugang을 추가했어요.
경기플러스 화면에서 수강신청 페이지 바로가기 버튼을 만들었습니다.
수강신청 페이지를 최대한 본떠 UI를 구성했어요.
소망가방을 사용한 수강신청부터 구현하기로 정했고, 나머지 탭 버튼은 비활성화했어요.
더미 데이터를 사용하기 위한 Data 디렉토리를 생성하고, 내부에 더미 데이터를 넣었습니다.
더미 데이터는 ChatGPT를 사용해 생성했어요.
모의 수강신청 화면에서 신청, 삭제에 해당하는 부분은 차후에 버튼이 들어가게 돼요. 이후에 작업할 예정입니다.

To Reviewer

파일 구조와 스타일링 등의 부분에서, 개선이 필요한 부분이 보인다면 알려주세요.
더 나은 타입 선언이나 상수 핸들링 방법이 있다면 조언 부탁드립니다.

Screenshot

changeset-bot · 2025-01-15T06:00:05Z

🦋 Changeset detected

Latest commit: 0e114aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@clab-platforms/time	Minor
@clab-platforms/icon	Minor
@clab-platforms/land	Patch
@clab-platforms/member	Patch
@clab-platforms/design-system	Patch
@clab-platforms/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gwansikk · 2025-01-15T06:03:33Z

@cho4u4o pnpm-lock.yaml 충돌을 해결해주세요~

gwansikk · 2025-01-15T14:17:34Z

PR 본문에 키워드로 이슈를 연결해주세요

ref:

https://docs.github.com/ko/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

yummjin · 2025-01-15T14:26:12Z

PR 본문에 키워드로 이슈를 연결해주세요

ref:

https://docs.github.com/ko/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

#256 이슈를 PR에 연결하면 되나요?

gwansikk · 2025-01-15T14:45:31Z

PR 본문에 키워드로 이슈를 연결해주세요
ref:

https://docs.github.com/ko/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

#256 이슈를 PR에 연결하면 되나요?

이슈를 닫으려면 closed:, PR을 다르게 하여 이어서 하려면 related: 키워드를 달아주세요

gwansikk

수정하여 다시 리뷰를 받고자 하면 오른쪽 상단의 리뷰 재요청을 눌러주세요

apps/time/src/widgets/sugang/ui/SugangTableView.tsx

apps/time/src/widgets/sugang/model/constants/table.ts

apps/time/src/widgets/sugang/ui/SugangLayout.tsx

apps/time/src/widgets/sugang/ui/SugangTableView.tsx

apps/time/src/widgets/sugang/ui/SugangLayout.tsx

SWARVY

이 부분에 대해서만 수정 요청 드립니다. 수고 많으셨어요 :)

apps/time/src/widgets/sugang/data/data.ts

Co-authored-by: 신현호 <[email protected]>

gwansikk · 2025-01-27T12:26:09Z

apps/time/package.json

"@types/react": "^18", "@types/react-dom": "^18",

리액트 타입도 19 버전 대응해주세요

SWARVY

위에꺼 수정한다음 머지해주시면 될 것 같습니다 :)

yummjin added 21 commits December 23, 2024 00:40

chore(time): next, react, react-dom 버전 업그레이드

e4c523e

docs(time): add SUGANG into path

c7a2611

feat(time): add sugang component

d53d327

feat(time): add sugang page basic layout

3528b27

feat(time): add kgu logo

b578115

feat(time): add sugang page button to navigate sugang page

5428fcf

feat(time): make data constant

9139a58

feat(time): define types

44a089a

feat(time): make hook to render contents by pages and modes

92d22bd

docs(time): fix name of export

0af3a33

feat(time): get button data from constant

48874a3

feat(time): make sugang table view component

e35a7c5

refactor(time): divide table title into other file

afdaf0a

feat(time): change menu icon to button

36e6a23

feat(time): add dummy data

d94cd86

refactor(time): remove project to start from base

2fbc4d1

feat(time): make basic layout of sugang page

f6ee9eb

feat(time): make reused data constant

9c6bbfa

feat(time): make dummy data

73dd019

feat(time): make types of table header and elements

320ca71

feat(time): add table view component, use dummy data

a1f5c75

yummjin added ✨ Feature 새로운 기능 명세 및 개발 ⏰ Time time 프로젝트 관련 labels Jan 15, 2025

yummjin self-assigned this Jan 15, 2025

yummjin requested a review from Jeong-Ag as a code owner January 15, 2025 06:00

yummjin requested review from gwansikk and SWARVY January 15, 2025 06:00

Create metal-rockets-hear.md

33e2399

yummjin and others added 3 commits January 15, 2025 17:07

feat(time): add KguLogo icon file

ff3598f

refactor(time): delete KguLogo file to fix CI

74df144

fix(time): fix CI error due to icon package issue

328698c

yummjin linked an issue Jan 15, 2025 that may be closed by this pull request

[Time] 모의 수강신청 페이지 개발 #256

Open

3 tasks

yummjin removed a link to an issue Jan 15, 2025

[Time] 모의 수강신청 페이지 개발 #256

Open

3 tasks

gwansikk requested changes Jan 16, 2025

View reviewed changes

apps/time/src/widgets/sugang/ui/SugangTableView.tsx Outdated Show resolved Hide resolved

yummjin added 2 commits January 16, 2025 13:43

refactor(time): separate table title to constants

92e1f6d

refactor(time): import constant table title

8d65982

yummjin requested a review from gwansikk January 16, 2025 04:44

gwansikk reviewed Jan 16, 2025

View reviewed changes

apps/time/src/widgets/sugang/model/constants/table.ts Outdated Show resolved Hide resolved

Update apps/time/src/widgets/sugang/model/constants/table.ts

ee71885

SWARVY reviewed Jan 26, 2025

View reviewed changes

apps/time/src/widgets/sugang/ui/SugangLayout.tsx Outdated Show resolved Hide resolved

apps/time/src/widgets/sugang/ui/SugangTableView.tsx Show resolved Hide resolved

apps/time/src/widgets/sugang/ui/SugangLayout.tsx Outdated Show resolved Hide resolved

SWARVY requested changes Jan 26, 2025

View reviewed changes

apps/time/src/widgets/sugang/data/data.ts Outdated Show resolved Hide resolved

yummjin and others added 3 commits January 26, 2025 17:44

refactor(time): add space between variables and return

8deb054

Co-authored-by: 신현호 <[email protected]>

refactor(time): move mock-up data

50f3a82

refactor(time): apply border and divide in parent component

fea3421

yummjin requested review from SWARVY, gwansikk and Jeong-Ag January 27, 2025 08:03

Merge branch 'main' into feature/256

ac5e6d8

gwansikk approved these changes Jan 27, 2025

View reviewed changes

apps/time/package.json Outdated

Copy link

Member

gwansikk Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@types/react": "^18", "@types/react-dom": "^18",

리액트 타입도 19 버전 대응해주세요

SWARVY approved these changes Jan 27, 2025

View reviewed changes

Jeong-Ag approved these changes Jan 27, 2025

View reviewed changes

yummjin force-pushed the feature/256 branch from bee81fc to ac5e6d8 Compare January 28, 2025 07:03

yummjin force-pushed the feature/256 branch from 465aace to ac5e6d8 Compare February 9, 2025 08:59

Merge branch 'main' into feature/256

0e114aa

yummjin merged commit 6a0ffe4 into main Feb 10, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(time): 모의 수강신청 페이지 개발 #263

feat(time): 모의 수강신청 페이지 개발 #263

yummjin commented Jan 15, 2025 •

edited

Loading

changeset-bot bot commented Jan 15, 2025 •

edited

Loading

gwansikk commented Jan 15, 2025 •

edited

Loading

gwansikk commented Jan 15, 2025

yummjin commented Jan 15, 2025 •

edited by gwansikk

Loading

gwansikk commented Jan 15, 2025

gwansikk left a comment

SWARVY left a comment

gwansikk Jan 27, 2025

SWARVY left a comment

feat(time): 모의 수강신청 페이지 개발 #263

feat(time): 모의 수강신청 페이지 개발 #263

Conversation

yummjin commented Jan 15, 2025 • edited Loading

Summary

Tasks

To Reviewer

Screenshot

changeset-bot bot commented Jan 15, 2025 • edited Loading

🦋 Changeset detected

gwansikk commented Jan 15, 2025 • edited Loading

gwansikk commented Jan 15, 2025

yummjin commented Jan 15, 2025 • edited by gwansikk Loading

gwansikk commented Jan 15, 2025

gwansikk left a comment

Choose a reason for hiding this comment

SWARVY left a comment

Choose a reason for hiding this comment

gwansikk Jan 27, 2025

Choose a reason for hiding this comment

SWARVY left a comment

Choose a reason for hiding this comment

yummjin commented Jan 15, 2025 •

edited

Loading

changeset-bot bot commented Jan 15, 2025 •

edited

Loading

gwansikk commented Jan 15, 2025 •

edited

Loading

yummjin commented Jan 15, 2025 •

edited by gwansikk

Loading