Skip to content

Commit

Permalink
Post-merge fix-ups.
Browse files Browse the repository at this point in the history
  • Loading branch information
fasaxc committed Feb 24, 2020
1 parent fdacebb commit 1b248a7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
9 changes: 5 additions & 4 deletions fv/rule_metadata_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// +build fvtests

// Copyright (c) 2019-2020 Tigera, Inc. All rights reserved.
// Copyright (c) 2020 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -14,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// +build fvtests

package fv_test

import (
Expand All @@ -22,6 +22,7 @@ import (
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"

"github.com/projectcalico/felix/fv/connectivity"
"github.com/projectcalico/felix/fv/containers"
"github.com/projectcalico/felix/fv/infrastructure"
"github.com/projectcalico/felix/fv/utils"
Expand Down Expand Up @@ -157,7 +158,7 @@ var _ = Describe("Rule Metadata tests", func() {
// This test case verifies that "interesting" annotations like newlines and unicode don't break
// Felix's iptables handling code, which parses the output of iptables-save
It("should allow connectivity between workloads", func() {
cc := &workload.ConnectivityChecker{
cc := &connectivity.Checker{
ReverseDirection: false,
Protocol: "tcp",
}
Expand Down
11 changes: 6 additions & 5 deletions fv/spoof_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build fvtests

// Copyright (c) 2020 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -14,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// +build fvtests

package fv_test

import (
Expand All @@ -22,6 +22,7 @@ import (
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"

"github.com/projectcalico/felix/fv/connectivity"
"github.com/projectcalico/felix/fv/infrastructure"
"github.com/projectcalico/felix/fv/workload"
)
Expand All @@ -31,7 +32,7 @@ var _ = Describe("Spoof tests", func() {
infra infrastructure.DatastoreInfra
felixes []*infrastructure.Felix
w [3]*workload.Workload
cc *workload.ConnectivityChecker
cc *connectivity.Checker
)

teardownInfra := func() {
Expand Down Expand Up @@ -60,7 +61,7 @@ var _ = Describe("Spoof tests", func() {

spoofTests := func() {
It("should drop spoofed traffic", func() {
cc = &workload.ConnectivityChecker{}
cc = &connectivity.Checker{}
// Setup a spoofed workload. Make w[0] spoof w[2] by making it
// use w[2]'s IP to test connections.
spoofed := &workload.SpoofedWorkload{
Expand All @@ -79,7 +80,7 @@ var _ = Describe("Spoof tests", func() {
})

It("should allow workload's traffic if workload spoofs its own IP", func() {
cc = &workload.ConnectivityChecker{}
cc = &connectivity.Checker{}
// Setup a "spoofed" workload. Make w[0] spoof itself.
spoofed := &workload.SpoofedWorkload{
Workload: w[0],
Expand Down

0 comments on commit 1b248a7

Please sign in to comment.