Skip to content

Commit

Permalink
commands: disable services for commands running in chroot
Browse files Browse the repository at this point in the history
Disabled services start/stop for commands running in chroot.
This also prevents services from start during packages install.

Signed-off-by: Denis Pynkin <[email protected]>
  • Loading branch information
d4s committed Oct 26, 2017
1 parent d8a6fe1 commit 0993e19
Show file tree
Hide file tree
Showing 2 changed files with 81 additions and 0 deletions.
7 changes: 7 additions & 0 deletions commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ func (cmd Command) Run(label string, cmdline ...string) error {
exe.Env = append(os.Environ(), cmd.extraEnv...)
}

// Disable services start/stop for commands running in chroot
if cmd.ChrootMethod != CHROOT_METHOD_NONE {
services := ServiceHelper{cmd.Chroot}
services.Deny()
defer services.Allow()
}

err := exe.Run()
w.flush()
q.Cleanup()
Expand Down
74 changes: 74 additions & 0 deletions os.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package debos

import (
"fmt"
"os"
"path"
)

const debianPolicyHelper = "/usr/sbin/policy-rc.d"

/*
ServiceHelper is used to manage services.
Currently supports only debian-based family.
*/

type ServiceHelper struct {
Rootdir string
}

type ServicesManager interface {
Allow() error
Deny() error
}

/*
Allow() allows to start/stop services on OS level.
*/
func (s *ServiceHelper) Allow() error {

helperFile := path.Join(s.Rootdir, debianPolicyHelper)

if _, err := os.Stat(helperFile); os.IsNotExist(err) {
return nil
}
if err := os.Remove(helperFile); err != nil {
return err
}
return nil
}

/*
Deny() prohibits to start/stop services on OS level.
*/
func (s *ServiceHelper) Deny() error {

helperFile := path.Join(s.Rootdir, debianPolicyHelper)
var helper = []byte(`#!/bin/sh
exit 101
`)

if _, err := os.Stat(helperFile); os.IsExist(err) {
return fmt.Errorf("Policy helper file '%s' exists already", debianPolicyHelper)
}
if _, err := os.Stat(path.Dir(helperFile)); os.IsNotExist(err) {
// do not try to do something if ".../usr/sbin" is not exists
return nil
}
pf, err := os.Create(helperFile)
if err != nil {
return err
}
defer pf.Close()

if _, err := pf.Write(helper); err != nil {
return err
}

if err := pf.Chmod(0755); err != nil {
return err
}

return nil
}

0 comments on commit 0993e19

Please sign in to comment.