Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magicAuthLink and passwordResetLink functionality from @keystone-6/auth #9245

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Jul 30, 2024

This pull request removes the magicAuthLink and passwordResetLink functionality from @keystone-6/auth. The rationale is that this functionality is often unused and consequently unmaintained within the project.

While passwordResetLink functionality can be helpful, most projects I have seen have implemented their own versions, often finding the provided interface unsatisfactory. The community has shown that @keystone-6/auth does not adequately support this functionality, as seen in discussions like this one, leaving developers to write most of the feature themselves.

This change will reduce the complexity of the @keystone-6/auth module, which is a precursor to initiatives such as #8097.
#8097 and other initiatives seek to add support for advanced authentication methods (like MFA) and functionality to Keystone in a new and improved manner.

If you know of any projects that rely on these features and would be adversely affected by their removal, please share your experiences and use cases.

Copy link

codesandbox-ci bot commented Jul 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c27a3b8:

Sandbox Source
@keystone-6/sandbox Configuration

@andy-blum
Copy link

I'm using this functionality on a project right now and would be sad to see it go.

most projects I have seen have implemented their own versions, often finding the provided interface unsatisfactory.

I'm curious what shortcomings people are seeing in this and what DIY systems they're building. If this functionality is removed, I'd hope to see a good replacement suggestion in documentation.

@dcousens
Copy link
Member Author

dcousens commented Aug 2, 2024

@andy-blum fair point, maybe I can add an example to this pull request, and from there we can discuss how the example fairs compared to the inbuilt functionality.

@borisno2
Copy link
Member

borisno2 commented Aug 4, 2024

Looks good @dcousens - just put in a rough first pass example of a magicAuthExample without using the auth package in case that is useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants