Fix input value for Decimal validate hook (#9262)

keystonejs · Sep 3, 2024 · d543e60 · d543e60
1 parent 4f8f925
commit d543e60
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/short-rocks-design.md b/.changeset/short-rocks-design.md
@@ -0,0 +1,5 @@
+---
+"@keystone-6/core": patch
+---
+
+Fixes `decimal` field bug (#8597) by parsing to `Decimal` before lessThan / greaterThan checks
diff --git a/packages/core/src/fields/types/decimal/index.ts b/packages/core/src/fields/types/decimal/index.ts
@@ -48,7 +48,14 @@ function parseDecimalValueOption (meta: FieldData, value: string, name: string)
   return decimal
 }
 
-export function decimal <ListTypeInfo extends BaseListTypeInfo>(config: DecimalFieldConfig<ListTypeInfo> = {}): FieldTypeFunc<ListTypeInfo> {
+function safeParseDecimalValueOption (meta: FieldData, value: string | null | undefined, name: string): Decimal | null | undefined {
+  if (value === null || value === undefined) {
+    return value
+  }
+  return parseDecimalValueOption(meta, value, name)
+}
+
+export function decimal <ListTypeInfo extends BaseListTypeInfo> (config: DecimalFieldConfig<ListTypeInfo> = {}): FieldTypeFunc<ListTypeInfo> {
   const {
     isIndexed,
     precision = 18,
@@ -107,7 +114,7 @@ export function decimal <ListTypeInfo extends BaseListTypeInfo>(config: DecimalF
     } = makeValidateHook(meta, config, ({ resolvedData, operation, addValidationError }) => {
       if (operation === 'delete') return
 
-      const value: Decimal | null | undefined = resolvedData[meta.fieldKey]
+      const value = safeParseDecimalValueOption(meta, resolvedData[meta.fieldKey], 'value')
       if (value != null) {
         if (min !== undefined && value.lessThan(min)) {
           addValidationError(`value must be greater than or equal to ${min}`)