Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #522
PR fixes CI. Summary of the changes:
Removed property
-Dkeycloak.profile.feature.account2=disabled
. This property is not used for anything in latest Keycloak nightly build as latest Keycloak supports just account3Removed environment variables
KEYCLOAK_ADMIN
andKEYCLOAK_ADMIN_PASSWORD
when starting the server. The variables are not needed as admin user is present anyway in the realm JSON filetest/fixtures/auth-utils/nodejs-test-realm.json
, which is used when importing the JSON file. When those environment variables are used, server fails to start due the DB constraint as there is an attempt to create admin user twice (I guess this check was not present in previous Keycloak server versions and hence it worked)Updated Java to 21 for starting the server
Updating chromedriver to 131. Previous version of chromedriver was very old version 105, which does not work with latest Chrome and all the tests using chrome were failing. I've used command
npm update chromedriver
and all the related changes are done in the filepackage-lock.json
(I am using separate commit for update chromedriver and all the changes in package-lock.json as it is huge amount of changes. But I can squash to same commit if it is preferred)Updating node.js version in GH actions from 16 to 18. So now it is testing with 14 and 18. For some reason, the web tests did not worked with chromedriver with node 16. The newer version 18 works as well as older version 14 works fine. It might be an issue specific to node 16. Is it an issue to upgrade node version for testing? The node.js keycloak quickstart is using version 18 as well.
For the reference, here is the issue, which I saw in the CI with node 16: