Require HepMC3 for rivet

[tmadlener]

BEGINRELEASENOTES

• Require rivet to be built against HepMC3 instead of the default HepMC2 (which is deprecated)

ENDRELEASENOTES

Discovered by @dirkzerwas and @apricePhy

This should be pretty trivial to include without triggering a rebuild of large parts of the stack (as far as I can tell it's thepeg and herwig3). I have tested this locally and things work there.

@jmcarcell can this be picked up for tomorrows nightlies?

[tmadlener]

Actually, this works for rivet@4:, but for [email protected] I run into a configure error, because it parses the HepMC3 version wrongly:

     160    configure: Found HepMC3 library at /home/madlener/work/.spack/spackages/skylake-ubuntu24.04-gcc13.2.0/hepmc3/3.3.0-cj6pxi/lib/libHepMC3.so
     161    configure: Found HepMC3 header directory at /home/madlener/work/.spack/spackages/skylake-ubuntu24.04-gcc13.2.0/hepmc3/3.3.0-cj6pxi/include
     162    /tmp/madlener/spack-stage/spack-stage-rivet-3.1.10-t67yz2tve6hssigdskrnydnfwzr7dadm/spack-src/configure: line 20912: let: hepmc_third=: syntax error: operand expected (error tok
            en is "=")
     163    configure: HepMC version is 3.03.00 -> 33
  >> 164    configure: error: HepMC3 version 3.1.1 or later is required.

[apricePhy]

Actually, this works for rivet@4:, but for [email protected] I run into a configure error, because it parses the HepMC3 version wrongly:

     160    configure: Found HepMC3 library at /home/madlener/work/.spack/spackages/skylake-ubuntu24.04-gcc13.2.0/hepmc3/3.3.0-cj6pxi/lib/libHepMC3.so
     161    configure: Found HepMC3 header directory at /home/madlener/work/.spack/spackages/skylake-ubuntu24.04-gcc13.2.0/hepmc3/3.3.0-cj6pxi/include
     162    /tmp/madlener/spack-stage/spack-stage-rivet-3.1.10-t67yz2tve6hssigdskrnydnfwzr7dadm/spack-src/configure: line 20912: let: hepmc_third=: syntax error: operand expected (error tok
            en is "=")
     163    configure: HepMC version is 3.03.00 -> 33
  >> 164    configure: error: HepMC3 version 3.1.1 or later is required.

For completeness, this was fixed in https://gitlab.com/hepcedar/rivet/-/merge_requests/904/ (Thomas is already aware)

[tmadlener]

There will be a new rivet 3.1.11 patch release that has a fix for building it with HepMC 3.3. I think it's easiest to simply wait for that with this.

(rivet@4 breaks thepeg and herwig3)

[jmcarcell]

I'll do an update in the next days and pick up all the latest versions, then rivet 4.X.X will be installed and we can add this.

[tmadlener]

rivet 4.x.x will break thepeg / herwig. I am actually not sure whether this is already reflected in the spack packages.

[apricePhy]

There will be a new rivet 3.1.11 patch release that has a fix for building it with HepMC 3.3. I think it's easiest to simply wait for that with this.

(rivet@4 breaks thepeg and herwig3)

Hi @tmadlener, Rivet 3.1.11 and YODA 1.9.11 have now been released

[tmadlener]

Nice, let me add them to upstream spack so that we can pick them up here to get this moving again.

[tmadlener]

Upstream PR: spack/spack#48141

[tmadlener]

rivet 4.x.x will break thepeg / herwig. I am actually not sure whether this is already reflected in the spack packages.

spack/spack#48142 will make sure to not fall into that issue accidentally

[tmadlener]

We probably haven't picked up all of the upstream PRs yet with our current spack commit, but they have landed upstream. Should I add the cherry-picks here?

[jmcarcell]

I can confirm rivet 4.x doesn't build. I'll may have a look but for now restricting to 3.x is fine. We're missing adding +rivet to thepeg (I guess we want this? otherwise we can add rivet to the key4hep-stack because I just concretized and rivet was not part of the spec - I can add this. I'll merge this after #699

[jmcarcell]

For some reason even though the default is to build thepeg with +rivet concretization (on Ubuntu 22.04, Ubuntu 24.04 and Alma 9) concretizes to thepeg~rivet so I had to require it in #700.