key4hep-stack: bump minimal catch2 version #496
Conversation
packages/key4hep-stack/package.py
Outdated
| @@ -83,7 +83,7 @@ class Key4hepStack(BundlePackage, Key4hepPackage): | |||
|
|
|||
| depends_on('cepcsw') | |||
|
|
|||
| depends_on('catch2@3.0.1:', when='+devtools') | |||
| depends_on('[email protected]:', when='+devtools') | |||
There was a problem hiding this comment.
I don't think we need this. The dependency will come from podio if it's needed in podio. Also it wouldn't be possible to build an older version of podio with this change. It would be better to just remove the version and let the packages require whichever version they need.
There was a problem hiding this comment.
I think we have to keep catch2 as a dependency for the key4hep-stack as it is only a test dependency in many cases. I agree on the version. I will remove it.
There was a problem hiding this comment.
I just realized we need to keep @3: because prior to that catch2 did not build the static library to link against.
There was a problem hiding this comment.
We still don't need @3: since it will try to install the latest version anyway so it would only be useful in case someone was having an environment with something that required 2.x and 3.x at the same time, or specifying manually to install catch2 but this is rare
Will become necessary with AIDASoft/podio#402