Limit the RNTuple backwards compatibility to podio 1.2 #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2025
|
Maybe we should keep this PR open as a reminder? And then once 1.3 is ready we fix it. Otherwise the test will stop running and it would be possible for no one to notice. |
tmadlener
commented
Apr 15, 2025
tmadlener
force-pushed
the
limit-rntuple-compat-tests
branch
2 times, most recently
from
174d767 to
d25463b
Compare
|
Merging this once CI has passed to unblock https://github.com/AIDASoft/podio/actions/runs/14727724869/job/41334334613?pr=711 This will momentarily not run the rntuple backwards compatibility checks, but pick them up again once podio has a 1.3 tag. |
tmadlener
force-pushed
the
limit-rntuple-compat-tests
branch
from
d25463b to
8cd0f08
Compare
tmadlener
force-pushed
the
limit-rntuple-compat-tests
branch
from
8cd0f08 to
b257950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
The file we download has been written with podio 1.2, and AIDASoft/podio#711 changes the storage details of the metadata for the podio RNTuple backend. Once that PR is merged we can update this file and change the conditions for this check again.