Make associations links and prepare them for a potential introduction of templated links #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
reviewed
Jul 17, 2024
tmadlener
force-pushed
the
prepare-podio-associations
branch
from
18f56a1
to
d95a41b
Compare
m-fila
reviewed
Jul 18, 2024
tmadlener
force-pushed
the
prepare-podio-associations
branch
2 times, most recently
from
a734aee
to
46065fd
Compare
|
This now implements the final proposal from #344 for the naming of the types as well. In my local testing this is fully transparent and we can deal with deprecation warnings in downstream packages without blocking this. |
tmadlener
changed the title
Inlining will omit creating symbols for these functions which leads to issues when dynamically loading a library that uses these methods
tmadlener
force-pushed
the
prepare-podio-associations
branch
from
2dcc3d8
to
2bf9180
Compare
This was referenced Jul 30, 2024
|
Note that something that is not transparent is python bindings but I don't think we have lots of them for Links. |
jmcarcell
added a commit
to key4hep/k4MarlinWrapper
that referenced
this pull request
Aug 6, 2024
jmcarcell
added a commit
to key4hep/k4FWCore
that referenced
this pull request
Aug 9, 2024
jmcarcell
added a commit
to key4hep/k4FWCore
that referenced
this pull request
Aug 9, 2024
jmcarcell
added a commit
to key4hep/k4Reco
that referenced
this pull request
Aug 9, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
fromandtoin preparation for a transparent introduction of templated associations in podio (Add templated links between arbitrary datatypes AIDASoft/podio#257)AssociationtoLinkand make naming more consistentENDRELEASENOTES
PRs to keep things working downstream after this has been merged: