-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support CSV #6
support CSV #6
Conversation
This is a pretty good start. One idea for a test would be to generate the index file and check if it's byte-identical to the index file created by the jsonl version. Since the taxicab data is relatively primitive types, this should be not too crazy to do. |
Hey Kevin, Sorry about the AWOLness, I've been pretty sick with the flu for the past week. I'm slowly feeling better and will have this feature up soon. Happy new year 🐉 :) |
No worries, it's the holidays anyways so everything is on higher latency. I also got sick with covid + a cold a two weeks ago so I know how it is, it seems like everyone has been getting sick :) Happy new year! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the tests, makes it super easy to figure out.
fixes #4
What this PR does
--jsonl
or-csv
flags to the CLI.NewIndexFile
and extendsSynchronize
for thecsv
datahandlerReadIndexFile
to handle various formatscsv
Index file <--->csv
readIndexFilecsv
Index file <--->jsonl
Index file