Skip to content

Commit

Permalink
MINOR: Cleanup GroupCoordinatorRecordHelpers (apache#17718)
Browse files Browse the repository at this point in the history
Reviewers: Jeff Kim <[email protected]>, Mickael Maison <[email protected]>, Chia-Ping Tsai <[email protected]>
  • Loading branch information
dajac authored Nov 8, 2024
1 parent 02b2fa0 commit f7d2a8c
Showing 1 changed file with 3 additions and 32 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -360,35 +360,6 @@ public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord(
);
}

/**
* Creates a ConsumerGroupCurrentMemberAssignment record.
*
* @param groupId The consumer group id.
* @param member The share group member.
* @return The record.
*/
public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord(
String groupId,
ShareGroupMember member
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
new ConsumerGroupCurrentMemberAssignmentKey()
.setGroupId(groupId)
.setMemberId(member.memberId()),
(short) 8
),
new ApiMessageAndVersion(
new ConsumerGroupCurrentMemberAssignmentValue()
.setMemberEpoch(member.memberEpoch())
.setPreviousMemberEpoch(member.previousMemberEpoch())
.setState(member.state().value())
.setAssignedPartitions(toTopicPartitions(member.assignedPartitions())),
(short) 0
)
);
}

/**
* Creates a ConsumerGroupCurrentMemberAssignment tombstone.
*
Expand Down Expand Up @@ -731,7 +702,7 @@ public static CoordinatorRecord newShareGroupSubscriptionMetadataRecord(
* @return The record.
*/
public static CoordinatorRecord newShareGroupSubscriptionMetadataTombstoneRecord(
String groupId
String groupId
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
Expand Down Expand Up @@ -929,8 +900,8 @@ public static CoordinatorRecord newShareGroupCurrentAssignmentRecord(
* @return The record.
*/
public static CoordinatorRecord newShareGroupCurrentAssignmentTombstoneRecord(
String groupId,
String memberId
String groupId,
String memberId
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
Expand Down

0 comments on commit f7d2a8c

Please sign in to comment.