TypeScript type definitions #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemcii
reviewed
Nov 3, 2018
| ): ( | ||
| component: ( | ||
| props: P & { | ||
| fieldProps: React.InputHTMLAttributes<HTMLInputElement> |
There was a problem hiding this comment.
React.HTMLAttributes rather than React.InputHTMLAttributes<HTMLInputElement> might be a better choice, I thought about adding all variants but that'd require type assertion.
|
What do you think about modularizing type definitions, @Ell10t? |
|
No objections here, if it makes it more manageable it's probably not a bad idea. |
|
@Ell10t I will try to break it down then. Apart from that, the only crucial thing that is left is a type definition of that |
|
Alright, if I get time I'll have a look into the generics as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a basic typings in TypeScript.
Subjected to merge after a prior discussion.