Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change hook point. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

miyucy
Copy link

@miyucy miyucy commented Mar 13, 2012

because deploy:symlink is deprecated from Capistrano v2.11.0 or above.

because `deploy:symlink` is deprecated from Capistrano v2.11.0 or above.
@walter
Copy link
Member

walter commented Mar 13, 2012

Thanks for the commit. Does create_symlink work in earlier versions of Cap? I don't want to break things for people still using earlier version of capistrano.

Of course, perhaps the best alternative is to specify that the capistrano dependency is for 2.11.0 or above. Thoughts?

@miyucy
Copy link
Author

miyucy commented Mar 14, 2012

Thanks for response.

Thanks for the commit. Does create_symlink work in earlier versions of Cap?
I don't want to break things for people still using earlier version of capistrano.

You right. create_symlink does not exist earlier version.

Of course, perhaps the best alternative is to specify that the capistrano dependency is for 2.11.0 or above. Thoughts?

Yes, I think too.

I think this problem has 3 solution.

  1. change gem dependency.
  2. change hook point to before finalize_update.
  3. check create_symlink are exist.

so sorry my poor english...

@walter
Copy link
Member

walter commented Mar 18, 2012

Yep, those seem to be the options. I'll have a think and get back to you.

Your English isn't perfect, but you are doing ok. Keep with it and thanks for making the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants