Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/aws-batch-script-runner #401

Merged
merged 5 commits into from
Mar 25, 2024
Merged

feat/aws-batch-script-runner #401

merged 5 commits into from
Mar 25, 2024

Conversation

brian-mulier-p
Copy link
Member

No description provided.

@brian-mulier-p brian-mulier-p self-assigned this Mar 21, 2024
@brian-mulier-p brian-mulier-p force-pushed the feat/aws-batch-script-runner branch from 9778c7f to c901cac Compare March 21, 2024 15:58
@brian-mulier-p brian-mulier-p force-pushed the feat/aws-batch-script-runner branch 2 times, most recently from 1716e19 to 7308ac2 Compare March 21, 2024 22:21
@brian-mulier-p brian-mulier-p force-pushed the feat/aws-batch-script-runner branch from 7308ac2 to d18bd0d Compare March 21, 2024 22:49
loicmathieu
loicmathieu requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner didn't implement job resuming, this is fine for now but it should be documented.
You can open a followup issue about being able to resume a running job in case a worker is restarted, for that you would need a stable job name.

@brian-mulier-p brian-mulier-p mentioned this pull request Mar 22, 2024
Closed
@brian-mulier-p
Copy link
Member Author

Follow-up issue: #402

@brian-mulier-p brian-mulier-p force-pushed the feat/aws-batch-script-runner branch from d983ed8 to 8e92d74 Compare March 22, 2024 13:35
@brian-mulier-p brian-mulier-p force-pushed the feat/aws-batch-script-runner branch from 8e92d74 to 9ca37be Compare March 22, 2024 14:25
@brian-mulier-p brian-mulier-p merged commit 2579b57 into master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu requested changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-mulier-p @loicmathieu