Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: chromeos: Add ChromiumOS tree and Clang kbuild jobs #995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laura-nao
Copy link
Contributor

Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new Clang kbuild jobs for both ARM64 and x86_64 Chromebooks.

@laura-nao laura-nao added the staging-skip Don't test automatically on staging.kernelci.org label Feb 4, 2025
@laura-nao
Copy link
Contributor Author

Please remove the staging-skip label if the changes look good enough for testing, I believe it requires a manual trigger for staging anyway.

Copy link

@10ne1 10ne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume you tested the chromeos branch with Clang 17 :)

Copy link
Contributor

@a-wai a-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it could be a bit more concise but there's nothing wrong with the current implementation.

Comment on lines 38 to 39
tree:
- chromiumos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tree:
- chromiumos
<<: *kbuild-clang-17-arm64-chromeos-rules

config/jobs-chromeos.yaml Outdated Show resolved Hide resolved
@nuclearcat nuclearcat removed the staging-skip Don't test automatically on staging.kernelci.org label Feb 4, 2025
@laura-nao
Copy link
Contributor Author

LGTM, it could be a bit more concise but there's nothing wrong with the current implementation.

Thanks for the feedback - I'll apply the fixes as suggested.

@laura-nao laura-nao force-pushed the wip/add-chromiumos-tree branch from 91422e4 to 0e8a9b9 Compare February 5, 2025 11:13
Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new
Clang kbuild jobs for both ARM64 and x86_64 Chromebooks.

Signed-off-by: Laura Nao <[email protected]>
@laura-nao
Copy link
Contributor Author

LGTM, I assume you tested the chromeos branch with Clang 17 :)

I ran just one manual LAVA job with a chromeos-6.12 build w/ Clang 17 (build was successful and boots) - see https://lava.collabora.dev/scheduler/job/17616230 for reference

I'll wait for the staging results to confirm if the other branches built successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants