Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: pipeline: Update bookworm-rt rootfs #700

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

musamaanjum
Copy link
Contributor

New package has been added to bookworm-rt rootfs. Hence update the URL to newly updated rootfs.

Related PR: kernelci/kernelci-core#2614

@musamaanjum
Copy link
Contributor Author

I've set the rootfs URL to staging. After verification I'll put URL of production before merging on this PR.

@a-wai
Copy link
Contributor

a-wai commented Jul 24, 2024

I've set the rootfs URL to staging. After verification I'll put URL of production before merging on this PR.

Sounds good, can you please set this PR as draft so it can't get merged as-is by accident?

@musamaanjum musamaanjum marked this pull request as draft July 24, 2024 09:04
@a-wai a-wai added the staging-skip Don't test automatically on staging.kernelci.org label Aug 6, 2024
config/pipeline.yaml Outdated Show resolved Hide resolved
@musamaanjum musamaanjum removed the staging-skip Don't test automatically on staging.kernelci.org label Aug 8, 2024
@musamaanjum musamaanjum marked this pull request as ready for review August 8, 2024 06:52
config/pipeline.yaml Outdated Show resolved Hide resolved
@nuclearcat
Copy link
Member

LAVA job referenced in link is from production, which is not updated yet

@musamaanjum
Copy link
Contributor Author

The test failed in reality as rtla isn't found. The test result reporting is wrong. Let's debug why failure happend:

kernelmsg (rt-tests-rtla-osnoise)
KernelCI node: [66bf60458ac59a075e697815](https://staging.kernelci.org:9000/viewer?node_id=66bf60458ac59a075e697815)
Result: PASS
Date: 2024-08-16T14:20:53.251000
Tree: stable-rt
Branch: v6.1-rt
Kernel version: v6.1.105-rt38
Commit: 8fe1d58eff313241a0c3187db014fbccaad0b680 (https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git)
Arch : arm
Platform : imx6q-sabrelite
Config: multi_v7_defconfig+preempt_rt
Compiler: gcc-12
Runtime: lava-collabora
Logs:
[lava_log](https://kciapistagingstorage1.file.core.windows.net/staging/rt-tests-rtla-osnoise-66bf5f908ac59a075e697801/log.txt.gz?sv=2022-11-02&ss=f&srt=sco&sp=r&se=2024-10-17T19:19:12Z&st=2023-10-17T11:19:12Z&spr=https&sig=sLmFlvZHXRrZsSGubsDUIvTiv%2BtzgDq6vALfkrtWnv8%3D)

From above node link, I've found the grand parent node (https://staging.kernelci.org:9000/viewer?node_id=66bf5f908ac59a075e697801) to find lava log.
https://kciapistagingstorage1.file.core.windows.net/staging/rt-tests-rtla-osnoise-66bf5f908ac59a075e697801/lava_callback.json.gz?sv=2022-11-02&ss=f&srt=sco&sp=r&se=2024-10-17T19:19:12Z&st=2023-10-17T11:19:12Z&spr=https&sig=sLmFlvZHXRrZsSGubsDUIvTiv%2BtzgDq6vALfkrtWnv8%3D

This log shows that older and wrong kselftest rootfs is being used:

name: rt-tests-rtla-osnoise
storage.kernelci.org/images/rootfs/debian/bookworm-kselftest/20240221.0

Why the bookworm-rt isn't being used here? @nuclearcat @pawiecz please can you help debug this?

@pawiecz
Copy link
Contributor

pawiecz commented Aug 19, 2024

@musamaanjum
Copy link
Contributor Author

@musamaanjum It looks like only depthcharge boot method currently supports nfsroot substitution. Boot methods for other bootloaders have hardcoded images in their templates, in this case u-boot template needs to be updated.

Many thanks @pawiecz. I was scratching my head over it from some time.

@nuclearcat @a-wai can we schedule the work to update the templates? You may have pre-planned it already. We should prioritize fixing rt-tests work as the work started on the rt maintainer's request and we don't want to lose his interest. (cc: @helen-fornazier as she is leading the community engagement work and can help in deciding the priority of this work.)

@a-wai
Copy link
Contributor

a-wai commented Aug 20, 2024

@musamaanjum this was trivial enough that I pushed kernelci/kernelci-core#2641

@a-wai
Copy link
Contributor

a-wai commented Aug 23, 2024

Setting staging-skip to allow testing #766

@a-wai a-wai added the staging-skip Don't test automatically on staging.kernelci.org label Aug 23, 2024
@pawiecz
Copy link
Contributor

pawiecz commented Aug 23, 2024

#766 has been merged, dropping staging-skip label to bring this PR back to staging

@pawiecz pawiecz removed the staging-skip Don't test automatically on staging.kernelci.org label Aug 23, 2024
@a-wai
Copy link
Contributor

a-wai commented Aug 23, 2024

Note: with #766 merged it now conflicts, so this also needs a rebase to be deployed.

New package has been added to bookworm-rt rootfs. Hence update the URL
to newly updated rootfs.

Signed-off-by: Muhammad Usama Anjum <[email protected]>
@musamaanjum
Copy link
Contributor Author

@a-wai Thanks for fixing. Rebased the PR.

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Most recently triggered Maestro Jobs (bottom) showed that the LAVA TestJob definition might still need some adjustments but the rootfs now contains necessary tools which should be enough to merge this PR as well as kernelci/kernelci-core#2614

@musamaanjum
Copy link
Contributor Author

I've collected the results on kernelci/kernelci-project#439 and fix issues under this ticket. Overall, 3/11 tests have issues in their executor script in https://github.com/Linaro/test-definitions.

@nuclearcat nuclearcat added this pull request to the merge queue Aug 28, 2024
Merged via the queue into kernelci:main with commit a57ba26 Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants